Upstreaming3

Open rpavlik opened this issue 4 years ago • 1 comments

A couple of fixes here, some are particularly important if you're using jnipp in a library (like the OpenXR loader) and thus don't have 100% control over when the thread gets attached/detached.

Dec 10 '21 00:12 rpavlik

@mitchdowd Is it possible to get these changes merged as I'm currently using them as well?

Oct 27 '22 08:10 rblenkinsopp

I was added to this repo as a committer, but didn't get any guidelines as to when to merge things. I can't review my own code, but if these changes also work for you that seems like a good test.

Nov 01 '22 14:11 rpavlik

I've certainly been using this branch for our usage, though I won't be hitting all of the fixes you've listed here. I was primarily using this version for the fixes around the manual thread attach.

Nov 03 '22 10:11 rblenkinsopp

Merged. Thanks for the contribution @rpavlik . I'm happy for you to self-approve and merge at this point.

Nov 26 '22 09:11 mitchdowd