django-modeladmin-reorder icon indicating copy to clipboard operation
django-modeladmin-reorder copied to clipboard

Published 20 hours ago • verified publisher icon mishbahr

Raise NameError if model specified in ADMIN_REORDER can't be found

Open pief opened this issue 8 years ago • 5 comments

Makes it easier to catch configuration mistakes that otherwise just tend to get overseen.

pief avatar Feb 06 '17 13:02 pief

Coverage Status

Coverage decreased (-0.009%) to 0.962% when pulling 792f2a40c5b53f72bc18370e19129ff4f3cb3b68 on pief:master into 6e3ea395fa27223e7b431267e879d6ad5ad55426 on mishbahr:master.

coveralls avatar Feb 06 '17 13:02 coveralls

IMHO a great idea!

But you can also raise an error, of 'app' is not found, too.

jedie avatar Mar 01 '17 10:03 jedie

Not sure I understand?

pief avatar Mar 01 '17 13:03 pief

Ah, i see. Wrong app name seems to raise an error, already.

jedie avatar Mar 01 '17 14:03 jedie

" Wrong app name seems to raise an error, already.", I'm not seeing this. I agree with original author with this PR, adding this PR will definitely help identify problem. I had a typo in my app name and took me a while to figure out why the app/models won't show up on admin list.

emilyzzz avatar Mar 11 '19 02:03 emilyzzz