Niklas Mischkulnig

Results 519 comments of Niklas Mischkulnig

Did you find any problems with this? A few tests will need to be updated because they now include the esmodule-helpers in dev mode, but otherwise I think we could...

Looks like it fails now after the nightly upgrade ``` = note: aarch64-unknown-linux-gnu-gcc: error: unrecognized command line option '-fuse-ld=lld' ```

Almost all tests are failing, but it's probably on master as well and unrelated to this PR.

See https://github.com/parcel-bundler/watcher/issues/156#issuecomment-1742551693 and https://github.com/parcel-bundler/watcher/issues/156#issuecomment-1750585673. This doesn't solve the underlying problem

This package also allows detecting changes between one-shot builds: https://github.com/parcel-bundler/watcher#querying

Yes, we definitely want this. It's just that somebody need to implement it. https://github.com/parcel-bundler/lightningcss has this approach as well, and that seems to work well. Previous discussion: https://github.com/parcel-bundler/parcel/issues/6483

This function gets called with either a concrete (set via options) backend or with `default`: https://github.com/parcel-bundler/watcher/blob/8dfd99440b8666e81cc6865f68697ab272dfe83d/src/Backend.cc#L26 All of these availability checks (apart from watchman) are really compile time checks, so...

Correct. Parcel doesn't use fsevents (the npm package), but fsevents (the C API).

This is because of https://parceljs.org/features/development/#development-target