Introduce built-in addon variables for OpenShift version

[agajdosi]

General information

Some addons might require differences for various OpenShift versions. For example, the xpaas addon should ideally apply different templates for 3.9, 3.10 and 3.11 OpenShift. To have this behaviour fully automated new built-in addon variable openshift-version would be practical. This variable should contain info about major and minor version of OpenShift (being string 3.9, 3.10 or 3.11).

[amitkrout]

@agajdosi We have already OpenShift-Version metadata field is in place. Please check [1] for more details

[1] https://docs.okd.io/latest/minishift/using/addons.html#addon-openshift-version-semantics

[agajdosi]

@amitkrout OpenShift-Version provides a way how to restrict the addon on some versions of OpenShift. However it does not provide a way how to get the information about actual version of OpenShift being run. It can't be used to differentiate the execution of addon based on OKD version.

[amitkrout]

@agajdosi This is what addons owner should take control of it. It's addons owner responsibility to confirm on which version of oc is compatible for the desired addons. So minishift provide a addons meta data field OpenShift-Version to resolve the propose.

@minishift/minishift-dev Please share your thoughts

[agajdosi]

@amitkrout OK, so in xpaas I want to separate the templates in directories v3.9, v3.10 so for each version the correct templates are applied. Two ways to do: use manually entered parameter for version, or have it as a variable. Using the OpenShift-Version restriction the only way I can take care of correct version is to restrict the addon for just one version of OpenShift - 3.9 or 3.10.

[praveenkumar]

On Tue 28 Aug, 2018, 11:37 AM Andreas Gajdosik, [email protected] wrote:

@amitkrout https://github.com/amitkrout OK, so in xpaas I want to separate the templates in directories v3.9, v3.10 so for each version the correct templates are applied. Two ways to do: use manually entered parameter for version, or have it as a variable. Using the OpenShift-Version restriction the only way I can take care of correct version is to restrict the addon for just one version of OpenShift - 3.9 or 3.10.

Yes, it would be good to have this as default add-on variable like we have for route, in future we can have different folder at least for xpass add-on which can applied as per openshift version.

—

You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/minishift/minishift/issues/2736#issuecomment-416462454, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZBlwoRDj513EiV62A3B9uRBu9qGKz4ks5uVN4ngaJpZM4WNsa0 .

[amitkrout]

Got it, If plan is to keep different dir in version level for addons like xpaas then it really make sense. Thanks for the details

[jorgemoralespou]

@agajdosi Not sure as a developer you will want the xpaas templates that were latest when the openshift version was released or if on the contrary you always want the latest version of the templates that should work? IMHO you're getting into deep waters if you want to support this. The openshift/library project should contain latest and the released versions, I would always install latest and refer to the developer to how to install a specific version in case needed.

[LalatenduMohanty]

+1 for providing the inbuilt variable for OpenShift version in minishift.

Not sure as a developer you will want the xpaas templates that were latest when the openshift version was released or if on the contrary you always want the latest version of the templates that should work? IMHO you're getting into deep waters if you want to support this.

@jorgemoralespou Nope, we are not supporting it. We will support released versions of templates. With minishift we will ship the released version of templates but we are thinking to provide an override which can download the latest templates from the respective repository e.g. minishift addon install --xpass --latest-online.

[jorgemoralespou]

--latest-online? What's the value?

[gbraad]

the only 'latest' we can know about, is a possible reference to the addon in the minishift-addons or minishift repo. Anythinbg beyond that will create unnecessary complexity to handle, eg. an upstream repo link to resolve from the addon? I'd rather not want to describe more metadata... and also do not think an online 'version file' (just as needed for --latest-online) will help... ... as this support is related to openshift + templates combination, and since people can choose the openshiftr version to deploy, we will have to crossmatch many versions ?

On Wed, Aug 29, 2018 at 4:37 AM, Jorge Morales Pou <[email protected]

wrote:

--latest-online? What's the value?

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/minishift/minishift/issues/2736#issuecomment-416731916, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHZkddzP03xxvzV5_vJZKWLmmG-MkWks5uVan7gaJpZM4WNsa0 .

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]

[praveenkumar]

the only 'latest' we can know about, is a possible reference to the addon in the minishift-addons or minishift repo. Anythinbg beyond that will create unnecessary complexity to handle, eg. an upstream repo link to resolve from the addon?

Agree, xpaas template and image stream is not something we have control over and till now we are always taking it from openshift-ansible repo. Adding any more stuff will increase the complexity of the addon.

minishift addon install --xpass --latest-online

@LalatenduMohanty what does this even mean and how do you map it?

[LalatenduMohanty]

@LalatenduMohanty what does this even mean and how do you map it?

It was supposed to get the latest image streams and templates for a particular version of Openshift. For example if the default version of OpenShift is 3.10 and Minishift instance is started with 3.11 then user can get image stream and template for 3.11 on the fly.

Yes, it sounds complex but I would rather do a spike to figure how complex it will be.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.