minishift-addons icon indicating copy to clipboard operation
minishift-addons copied to clipboard

Published 20 hours ago • verified publisher icon minishift

Adding Strimzi addon

Open matzew opened this issue 7 years ago • 21 comments

For https://github.com/minishift/minishift-addons/issues/163 I've added a Strimzi add-on!

matzew avatar Sep 29 '18 13:09 matzew

Can one of the admins verify this patch?

centos-ci avatar Sep 29 '18 13:09 centos-ci

@kameshsampath I've added a Strimzi add-on,

might be handy w/ your recent work.....

matzew avatar Sep 29 '18 13:09 matzew

@gbraad ah, yeah - sorry. that was an accident - pushed to early :-(

matzew avatar Sep 29 '18 14:09 matzew

Updated using the latest version of Strimzi.

@kameshsampath @gbraad any comments?

matzew avatar Oct 22 '18 07:10 matzew

Updated using the latest version of Strimzi.

@kameshsampath @gbraad any comments?

matzew avatar Oct 22 '18 07:10 matzew

Updated using the latest version of Strimzi.

@kameshsampath @gbraad any comments?

matzew avatar Oct 22 '18 07:10 matzew

updated to 0.8.1 of Strimzi

matzew avatar Oct 22 '18 07:10 matzew

looks good to me, its better to release for latest version when releasing first version of addon

kameshsampath avatar Oct 22 '18 08:10 kameshsampath

this is latest version

On Mon 22. Oct 2018 at 10:42, Kamesh Sampath [email protected] wrote:

looks good to me, its better to release for latest version when releasing first version of addon

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/minishift/minishift-addons/pull/164#issuecomment-431769763, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJnznMkVJIlJl4Z72GonLOvAJan1OS1ks5unYTXgaJpZM4XAg7J .

-- Sent from Gmail Mobile

matzew avatar Oct 22 '18 17:10 matzew

I know thats why I voted for it :)

kameshsampath avatar Oct 22 '18 17:10 kameshsampath

@gbraad I've addressed your original concerns - and it's now pointing to the latest

matzew avatar Oct 23 '18 08:10 matzew

@praveenkumar @gbraad updated w/ version requirements and also added a simple test

matzew avatar Oct 24 '18 08:10 matzew

add to whitelist.

praveenkumar avatar Oct 25 '18 06:10 praveenkumar

@matzew can you please squash the commit into single one (I can see 5 commits associated to this PR)?

praveenkumar avatar Oct 25 '18 07:10 praveenkumar

@praveenkumar I've squashed to be one commit - sorry for the noise !

matzew avatar Oct 25 '18 08:10 matzew

@gbraad can you take a look and if seem alright then let's merge it.

praveenkumar avatar Oct 25 '18 08:10 praveenkumar

@gbraad / @praveenkumar any comments on this ?

matzew avatar Oct 30 '18 09:10 matzew

retest this please

anjannath avatar Feb 08 '19 12:02 anjannath

@gbraad ping, I already approved it long back.

praveenkumar avatar Feb 08 '19 12:02 praveenkumar

Apart from the Var-Defaults change request, the add-on is working fine, all the deployments/operators are running :+1:

anjannath avatar Feb 11 '19 09:02 anjannath

+1 OK.

Waiting for the final changes

On Mon, Feb 11, 2019 at 5:43 PM Anjan Nath [email protected] wrote:

Apart from the Var-Defaults change request, the add-on is working fine, all the deployments/operators are running

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]

gbraad avatar Feb 11 '19 09:02 gbraad