minio-js
minio-js copied to clipboard
type lifeCycleRule incorrect
It seems that the typing of the Expiration key in lifeCycleRule is incorrect. Date, Days, DeleteMarker, DeleteAll have all become required since the last update. This creates a typing error when I call the setBucketLifecycle function. What should I do ?
https://github.com/minio/minio-js/blob/06758a5fdf462fbc21267c133959c3bb7fbd7873/src/internal/type.ts#L359
Looks they are optional.
I was referring inside the Expiration key. Date, Days, DeleteMarker, DeleteAll, they are all required.
https://github.com/minio/minio-js/blob/06758a5fdf462fbc21267c133959c3bb7fbd7873/src/internal/type.ts#L323
Yeah looks like.. we can mark them optional. Feel free to send a PR.
fixed as part of #1308