minio-js icon indicating copy to clipboard operation
minio-js copied to clipboard

type lifeCycleRule incorrect

Open juliebrunetto83 opened this issue 1 year ago • 4 comments

It seems that the typing of the Expiration key in lifeCycleRule is incorrect. Date, Days, DeleteMarker, DeleteAll have all become required since the last update. This creates a typing error when I call the setBucketLifecycle function. What should I do ?

juliebrunetto83 avatar Jun 17 '24 08:06 juliebrunetto83

https://github.com/minio/minio-js/blob/06758a5fdf462fbc21267c133959c3bb7fbd7873/src/internal/type.ts#L359

Looks they are optional.

prakashsvmx avatar Jun 17 '24 13:06 prakashsvmx

I was referring inside the Expiration key. Date, Days, DeleteMarker, DeleteAll, they are all required.

juliebrunetto83 avatar Jun 17 '24 13:06 juliebrunetto83

https://github.com/minio/minio-js/blob/06758a5fdf462fbc21267c133959c3bb7fbd7873/src/internal/type.ts#L323

Yeah looks like.. we can mark them optional. Feel free to send a PR.

prakashsvmx avatar Jun 17 '24 14:06 prakashsvmx

fixed as part of #1308

prakashsvmx avatar Jun 19 '24 03:06 prakashsvmx