minio-js icon indicating copy to clipboard operation
minio-js copied to clipboard

Published 20 hours ago • verified publisher icon minio

ci: bump dependencies; remove node 12 and node 14

Open aldy505 opened this issue 1 year ago • 9 comments

  • Bump dependencies on CI to use latest versions
  • Remove Node 12 and Node 14 tests, as we don't support them anymore. They're not maintained versions either.

On the package.json file, it is defined that the minimum of Node.js version is 16. So it makes sense to drop version 12 and 14.

https://github.com/minio/minio-js/blob/51cf376d29d805e8b2aae02653cf1779817409ad/package.json#L75-L77

aldy505 avatar Dec 10 '23 04:12 aldy505

should we also downgrade @types/node to v16？

trim21 avatar Dec 12 '23 19:12 trim21

should we also downgrade @types/node to v16？

@trim21 No need, right? We're bundling everything with Babel anyway.

aldy505 avatar Dec 13 '23 05:12 aldy505

should we also downgrade @types/node to v16？

@trim21 No need, right? We're bundling everything with Babel anyway.

we didn't bundle anything

trim21 avatar Dec 13 '23 10:12 trim21

should we also downgrade @types/node to v16？

@trim21 No need, right? We're bundling everything with Babel anyway.

we didn't bundle anything

I thought Babel was for transpiling to older Nodejs versions, no?

aldy505 avatar Dec 18 '23 13:12 aldy505

should we also downgrade @types/node to v16？

@trim21 No need, right? We're bundling everything with Babel anyway.

we didn't bundle anything

I thought Babel was for transpiling to older Nodejs versions, no?

yes, transpiling only

trim21 avatar Dec 18 '23 15:12 trim21

should we also downgrade @types/node to v16？

@trim21 No need, right? We're bundling everything with Babel anyway.

we didn't bundle anything

I thought Babel was for transpiling to older Nodejs versions, no?

yes, transpiling only

Ah that should be good enough.

Can I have this reviewed, please? @kaankabalak @prakashsvmx

aldy505 avatar Dec 19 '23 00:12 aldy505

the CI still looks for tests on old version of node 12 on windows/ubuntu Test on node 12.x and ubuntu-latest Test on node 12.x and windows-latest

We will check this. @aldy505

prakashsvmx avatar Dec 19 '23 05:12 prakashsvmx

@prakashsvmx Hi, any updates?

aldy505 avatar Feb 07 '24 01:02 aldy505

I think it requires some admin access at the org level , i will check further.

prakashsvmx avatar Feb 07 '24 04:02 prakashsvmx

should also remove file https://github.com/minio/minio-js/blob/master/src/internal/async.ts ....

trim21 avatar Apr 30 '24 20:04 trim21

also https://github.com/minio/minio-js/blob/114ba7a919223827142ae9f24da3ffe754fbc395/babel-register.js#L22

trim21 avatar Apr 30 '24 20:04 trim21