minio-js icon indicating copy to clipboard operation
minio-js copied to clipboard

WIP TypeScript code refactor

Open trim21 opened this issue 2 years ago • 1 comments

based on https://github.com/minio/minio-js/pull/1120 https://github.com/minio/minio-js/pull/1119

and close https://github.com/minio/minio-js/issues/1106

please don't review the details of this PR, it for staging the migration I have made.

all files have aleady been re-written in TS (with minor any)

just wait previous PR to me merged, the we can start to split this PR into smaller patch to seprated PR for code review.

We should migrate base files first, ts file should not import js file.

and minio.js (the Client class) is very large so we should create a typed base class and migrate methods progressively

trim21 avatar Apr 14 '23 02:04 trim21

@aldy505 I think it would be better to review the seprated pr instead this big one, so we don't need to review same code twice

trim21 avatar Apr 14 '23 10:04 trim21