minetest_game icon indicating copy to clipboard operation
minetest_game copied to clipboard

Farming: Mandatory definition fields, reformat documentation and code

Open HybridDog opened this issue 5 years ago • 6 comments

Some additional changes: Hoes only work if the node is pointed to from above. Test for nil player in the hoe on_use function. Properly test if the creative mod is installed. Hoe and plant description, inventory_image, etc. must be specified (when registering). Nodes with the field group must have all soil values in the node definition. Field nodes do not loose their param2 value (e.g. rotation) when they dry or get wet, or when hoed. The node above the hoed one is not checked for protection because that node is not changed; similarly, the node under a seed is not tested for protection.

HybridDog avatar Mar 21 '20 13:03 HybridDog

~Why is the cleanup in game_api related to doors included with this? Shouldn't that go into a separate PR? Or are you going to turn this into a general api cleanup PR?~

Sorry, having a bad day... just noticed the title mentions addtl changes.

TumeniNodes avatar Mar 21 '20 15:03 TumeniNodes

The door related changes are only whitespace removals from line ends; my text editor does this automatically.

HybridDog avatar Mar 21 '20 19:03 HybridDog

The three backticks are GitHub Favored only, whereas indenting is an "Official" notation. To support Markdown readers aside GitHub's web render, I'd like to not change the current style.

SmallJoker avatar Mar 26 '20 18:03 SmallJoker

To support Markdown readers aside GitHub's web render, I'd like to not change the current style.

I've changed it back. I hope that having the comments in a separate line makes it easier to read than comments at line ends.

HybridDog avatar Mar 27 '20 10:03 HybridDog

@HybridDog you can replace lbm action

action = function(pos, node)
	tick_again(pos)
end,

on this: action = tick_again Thank you for your work!

MoNTE48 avatar Mar 31 '20 10:03 MoNTE48

@HybridDog, it seems rebase is required...

MoNTE48 avatar Jun 09 '20 14:06 MoNTE48

Stale, closing.

sfan5 avatar Dec 24 '23 12:12 sfan5