minetest
minetest copied to clipboard
minetest
Remove gradients on buttons
This PR removes the default gradient on buttons:
To do
This PR is Ready for Review.
How to test
Look.
I prefer the current buttons. Others may prefer flat ones. A general solution would IMO be to use 9slice drawing for all buttons so that games and players could overwrite the textures (normal, hover, press) on demand.
Tested. Somehow looks better in-game than in screenshots. One small issue though: The arrows in scrollbars are a little low contrast.
I'm fine with using this in mainmenu.
For mods/subgames though, I'd prefer to have some sort of styling option for this. I don't care much about the default (IIRC, we wanted to make the default ugly anyway). But users (=server owners) should have the possibility to reproduce the classic experience.
we wanted to make the default ugly anyway
That's a terrible approach. If I open the engine for the first time, I shouldn't be pushed to run away and never open it again. Default should be pretty, not ugly
we wanted to make the default ugly anyway
That's a terrible approach. If I open the engine for the first time, I shouldn't be pushed to run away and never open it again. Default should be pretty, not ugly
If you open the game, you see the main menu, not the defaults for mods. (Btw. here's where that suggestion came from: https://irc.minetest.net/minetest-dev/2023-07-14#i_6096922)
(Btw. here's where that suggestion came from: irc.minetest.net/minetest-dev/2023-07-14#i_6096922)
To be clear, I was joking
you know , why not just add a way to configure the default looks of buttons and stuff like that , call it themes or something , the VIM/neoVIM approach (edit how do i exit VIM again?)
About the last point: they could be either separated more or put one next to the other without any space left
The arrows in scrollbars are a little low contrast.
As mentioned in a comment in #13909, it's possible to change the colour of these symbols. Would the symbols being white be better?
Would the symbols being white be better?
Yes, that would be better.
EDIT: Perhaps even in a separate PR that can be merged for 5.8.0.
Also I can't remember if I intentionally changed the background colour of tabs, it's most likely a side effect of changing the 3D face colour to make the non-gradiented buttons darker.
I think this behavior could be made toggleable somehow. What if I want gradients on my buttons?
@Bituvo custom main menu. Theoretically it's expected that any game changes it's graphics, so we're only left with the main menu
Not personally a fan but it would put Minetest a bit closer to current design trends. The loss of gradients seems like a loss, will that remain easy to do with mod code even if the engine styling is changed?
The scrollbars definitely need white arrows; there's way too little contrast otherwise. The scrollbar background should be a bit lighter too, or rather maybe the scrollbar colour made a bit lighter as I will propose below.
I find the text a bit more readable with the gradients; I think the brightness of the new buttons is on the low side. I know that makes it a higher contrast compared to a lighter shade, but reading white text on black is harder for quite a few people with astigmatism. The white colours on a dark background blur much worse with astigmatism than black text does on a white background. Therefore, overall colour value not being too dark also matters, not pure contrast ratio. There is room for less colour contrast while still remaining inside WCAG accessibility guidelines. It seems like the colour was chosen by sampling the colour on the bottom of the existing button gradient instead of nearer the middle.
I think the fact that there's no contrast between buttons and background is a problem. Can the main background shade be kept the same while the button shades are made lighter? The main menu looks terrible to me now:
With my proposal for lighter buttons, it would look more like this ("Sound Volume under cursor):
(I had to fill with the paint bucket in GIMP because I couldn't work out what colour is what in guiSkin.cpp in a short period; there's alpha values used so I couldn't just pick it with the colour picker tool either).
I'm not too bothered by this change either way as games should be providing their own button styling and we're planning on redesigning the mainmenu in the future, which would come with its own button design
An alternative to this PR would be to just change the mainmenu buttons, and leave game buttons as is
We've been stalling on a simple gradient change for half a year now, c'mon...
I do not like the proposed color palette of the PR. The 3D buttons provided a nice contrast on various backgrounds, hence the colors proposed in https://github.com/minetest/minetest/pull/13718#issuecomment-1848860128 might work better in some cases - but generally I would prefer to have this controlled by formspec prepends to allow contrast fine-tuning depending on where the button is used.
As how it currently is: :-1: from my side.