irrlicht icon indicating copy to clipboard operation
irrlicht copied to clipboard

GL loader work

Open sfan5 opened this issue 1 year ago • 1 comments

todo (not necessarily all here):

  • [x] make extpointer mandatory
  • [x] figure out why the first commit broke world rendering on gles2 ~~(not my fault?)~~
  • [x] Drop unused exts from COGLESCoreExtensionHandler
  • [ ] ~~Make COGLES2ExtensionHandler use loader~~
  • [ ] ~~Make COGLES1ExtensionHandler use loader~~
  • [ ] ~~Drop unused exts and functions from COpenGLExtensionHandler (big oof)~~
  • [ ] ~~Make COpenGLExtensionHandler use loader~~
  • [ ] Identify and migrate other GL calls
  • [x] Deal with glext.h ?!
  • [x] macOS support should automatically start working at this point

Edit: I crossed half out because I'm not actually sure what the way forward is. The GLES2 driver has some sort of unified stuff where the new support code uses GL instead of direct calls, while I assume GLES1 is meant to be dropped and GL to be replaced by GL3.

sfan5 avatar Jan 16 '24 20:01 sfan5

@numberZero thoughts?

sfan5 avatar Jan 18 '24 23:01 sfan5

(after requested in IRC)

I can confirm that OpenGL 2 still works (also with shaders) on Ubuntu/Linux, 64-bit. SDL2 / OpenGL 3 / OpenGL ES support not enabled.

SmallJoker avatar Feb 17 '24 12:02 SmallJoker

I can confirm that OpenGL (4.6) still works on Linux, with shaders. FSAA also still works. Browsed through the changes, all looks reasonable.

As stated above, only test on Linux.

lhofhansl avatar Feb 17 '24 19:02 lhofhansl

bad news: there's something wrong with either this PR or the unified GLES2 driver on Android: test

nothing useful to be seen in the log, of course

sfan5 avatar Feb 18 '24 14:02 sfan5

isn't this what it usually looks like when the Irrlicht shaders are missing?

grorp avatar Feb 18 '24 14:02 grorp

Yes, however I'm reasonably sure that they aren't missing. The assets ZIP has them at least.

Edit:

Added some debug output and loading them doesn't seem to be the issue:

02-18 15:32:07.331 31617   386 D Minetest: 2024-02-18 15:32:07: INFO[Main]: Irrlicht: Loaded 382 bytes for vertex shader Renderer2D.vsh
02-18 15:32:07.331 31617   386 D Minetest: 2024-02-18 15:32:07: INFO[Main]: Irrlicht: Loaded 334 bytes for frag shader Renderer2D.fsh
02-18 15:32:07.343 31617   386 D Minetest: 2024-02-18 15:32:07: INFO[Main]: Irrlicht: Loaded 382 bytes for vertex shader Renderer2D.vsh
02-18 15:32:07.343 31617   386 D Minetest: 2024-02-18 15:32:07: INFO[Main]: Irrlicht: Loaded 129 bytes for frag shader Renderer2D_noTex.fsh

sfan5 avatar Feb 18 '24 14:02 sfan5

this is what renderdoc has to say about it: grafik

also this: grafik

sfan5 avatar Feb 18 '24 20:02 sfan5

Fixed it.

sfan5 avatar Feb 21 '24 18:02 sfan5