MinecraftDev icon indicating copy to clipboard operation
MinecraftDev copied to clipboard

Published 20 hours ago • verified publisher icon minecraft-dev

Implemented Support for PlaceholderAPI Expansions

Open darbyjack opened this issue 5 years ago • 2 comments
trafficstars

This pull request implements support for PlaceholderAPI Expansions. The only thing I have yet to figure out is why it's not detecting properly to show the icon. Currently, it will appear as a Spigot project.

Other than that, I believe this PR is done. Open to feedback.

darbyjack avatar May 11 '20 02:05 darbyjack

You probably should have asked before doing this. DemonWav is doing a refactor to the project creator system, which means you will have to mostly rewrite this.

Earthcomputer avatar May 11 '20 08:05 Earthcomputer

The refactor is done, and from our discussion on Discord I think adding PlaceholderAPI as an enableable feature or extension on the existing platforms is the better option. With the new system you can potentially just create a single CreatorStep for PlaceholderAPI. Ping me on Discord if you have any questions.

DenWav avatar Jun 01 '20 02:06 DenWav