MinecraftDev icon indicating copy to clipboard operation
MinecraftDev copied to clipboard

New error inspection: "Invoker has the same method name as target method"

Open Octol1ttle opened this issue 1 year ago • 1 comments
trafficstars

Minecraft Development for IntelliJ plugin version

2024.1-1.8.0

Description of the feature request

In Mixins, if the invoker method has the same name as the target method, then non-obfuscated environments will encounter a StackOverflowError upon calling the method. Without a proficient understanding of how Mixin merges @Mixin classes with their targets, it may be difficult for developers to debug this. Having an inspection with an Error severity would help them notice this issue before it causes problems

Octol1ttle avatar Aug 01 '24 13:08 Octol1ttle

I would propose for this to be a warning, to match the warning level of making a method which does nothing except call itself.

Earthcomputer avatar Aug 02 '24 16:08 Earthcomputer