Minchao

Results 11 comments of Minchao

You can customize the http client: ref: https://github.com/guzzle/guzzle/blob/dc87640a8669b278af07f8af6d6147a0b148929c/src/Client.php#L225 ```php new Client([ 'httpClient' => new HttpClient(['verify' => false]), ]); ```

Hi @rmdhfz Thank you for pointing this out. To avoid property type error. Maybe we should prevent users from setting wrong parameters. When the parameter passed in through the [constructor...

Hi @ulpyuxa That will be great, but I'm not able to do this work at the moment. Any pull requests are very welcome! :)

Pull request welcome 😃

@romeouald Thank you for pointing this out. If you want to contribute, Pull request are very welcome 😃

印象中是三竹新版的 API,但還我沒測試過 XD ref https://github.com/minchao/mitake-php/issues/5#issue-489064895

謝謝 引入對 v2 API 支援,可能需考慮對當前 v1 用戶的相容,初步想到有兩種作法: - 透過一層 service 包裝來支援 v2,[範例](https://github.com/google/go-github/blob/378bcfd2d1d7a0e32308180b5beb06d3351ca9d1/github/github.go#L159-L162) - 使用 [Go Modules version](https://blog.golang.org/v2-go-modules) 來區分版本,[範例](https://github.com/google/go-github/blob/378bcfd2d1d7a0e32308180b5beb06d3351ca9d1/go.mod#L1)

@bestpika 謝謝,可以麻煩您協助 PR 修正嗎?😃

@nick66551 謝謝您,也非常歡迎 PR 喔。