Daniel Mendler

Oh this adds so much code. @alphapapa Could you please turn this into a reusable GitHub action, similar to purcell/setup-emacs@master? I think tarsius also maintains such a reusable action which...

Sure. I understand your points. It would just be my preference to not include or even edit any scripts, while I would use some action prepared by the upstream maintainer,...

> it seems like a severe anti-pattern to have to push commits to a remote clone in order to run linters. I have my local package-lint-flymake installed in Emacs for...

Thank you for this. It is probably a good idea to provide alternative exporters. However I have two questions or counter points I'd like to see discussed or sorted out...

My initial reaction was also to reject because of the separation grep/occur and file/buffer. However if grep+wgrep work well and the grep export can be seen as a generalization of...

@oantolin Iirc there was a feature request for export with context lines to occur.

@oantolin Yes, I'd also like to understand the real value of this addition better and why @artemkovalyov isn't happy with occur and occur-edit-mode. I don't think you can "run away"...

@artemkovalyov That's indeed an interesting feature! I wasn't aware of that. I think occur-edit-mode should be improved such that this is also supported.

On 11/22/22 18:10, Omar Antolín Camarena wrote: > ***@***.**** commented on this pull request. > > ------------------------------------------------------------------------ > > In embark-consult.el > : > >> + (contents (propertize (embark-consult--strip line)))...

@artemkovalyov Thanks, this looks quite good. I've added a few comments, mostly details. More importantly, please try to get the FSF assignment, see the description at https://protesilaos.com/emacs/modus-themes#h:111773e2-f26f-4b68-8c4f-9794ca6b9633.