Mickael Maison

Results 126 comments of Mickael Maison

Thanks @gunnarmorling for the review. I've pushed an update.

Thanks @gunnarmorling for the feedback! I've adjusted the output so it prints plugin configurations as you suggested, I agree it's more readable for plugins with long values. I've reused `Tuple`...

This is what I'm currently playing with: - `kcctl get plugins --all` to list all plugins - `kcctl describe plugin SomePlugin` to get the configdefs for `SomePlugin`

When I run this locally, I can only access pages under `Docs`, for anything else I get 404. Is it expected? I would be nice to preview the complete website.

I've kicked a new build: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12675/6/

@Justinwins Have you actually seen this exception in practice? `idleConsumerGroupsOffset` is used by 2 threads, one reader and one writer. The thread reading it, `syncGroupOffset`, does not iterate the map...

Thanks for the updates @OmniaGM. There's a test failure: ``` org.apache.kafka.common.KafkaException: The constructor of org.apache.kafka.clients.admin.ForwardingAdmin threw an exception at app//org.apache.kafka.common.utils.Utils.newParameterizedInstance(Utils.java:466) at app//org.apache.kafka.connect.mirror.MirrorClientConfig.forwardingAdmin(MirrorClientConfig.java:81) at app//org.apache.kafka.connect.mirror.MirrorMakerConfigTest.testClientConfigProperties(MirrorMakerConfigTest.java:107) ```

@mdedetrich Sorry for the delay. I hope to review your PR in the coming days. Please keep it again trunk, if we also want it in 3.3, we'll backport it.

@mdedetrich The KIP was accepted in 3.3 but we assumed it would get merged before feature freeze. Feature freeze happened last week (see https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+3.3.0) so it's now at @jsancio's discretion...

Thanks @mdedetrich, the current changes look good. I wonder if we should also add an integration test. We should be able to extend `MultipleListenersWithSameSecurityProtocolBaseTest` to test duplicate listeners. There may...