milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: fix rootcoord_entity_num metric bug

Open presburger opened this issue 5 days ago • 4 comments

#45579

presburger avatar Dec 01 '25 09:12 presburger

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: presburger To complete the pull request process, please assign liliu-z after the PR has been reviewed. You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Dec 01 '25 09:12 sre-ci-robot

@presburger

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  • build(deps): for dependency updates from Dependabot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] avatar Dec 01 '25 09:12 mergify[bot]

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Dec 01 '25 09:12 sre-ci-robot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 76.00%. Comparing base (dff62c5) to head (c619e66). :warning: Report is 46 commits behind head on master.

:x: Your project check has failed because the head coverage (76.00%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #45983       +/-   ##
===========================================
- Coverage   82.73%   76.00%    -6.73%     
===========================================
  Files         524     1888     +1364     
  Lines       82291   294943   +212652     
===========================================
+ Hits        68082   224179   +156097     
- Misses      14209    63332    +49123     
- Partials        0     7432     +7432     
Components Coverage Δ
Client 78.17% <ø> (∅)
Core 82.73% <ø> (ø)
Go 74.06% <45.16%> (∅)
Files with missing lines Coverage Δ
internal/rootcoord/quota_center.go 79.25% <100.00%> (ø)

... and 1363 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 01 '25 11:12 codecov[bot]