milvus
milvus copied to clipboard
feat: impl ComputePhraseMatchSlop for compute min slop for phrase match query
issue: https://github.com/milvus-io/milvus/issues/45890
ComputePhraseMatchSlop accepts three pararms:
- A string: query text
- Some trings: data texts
- Analyzer params,
Slop will be calculated for the query text with each data text in the context of phrase match where they are tokenized with tokenizer with analyzer params.
So two array will be returned:
- is_match: is phrase match can sucess
- slop: the related slop if phrase match can sucess, or -1 is cannot.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: SpadeA-Tang
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
- /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]
If you have any questions or requests, please contact @zhikunyao.
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
Codecov Report
:x: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 82.71%. Comparing base (5d0c8b1) to head (66e4beb).
:warning: Report is 32 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/core/src/segcore/phrase_match_c.cpp | 0.00% | 7 Missing :warning: |
| internal/core/thirdparty/tantivy/phrase_match.h | 0.00% | 7 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #45892 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 527 527
Lines 82488 82488
=======================================
Hits 68226 68226
Misses 14262 14262
| Components | Coverage Δ | |
|---|---|---|
| Client | ∅ <ø> (∅) |
|
| Core | 82.71% <0.00%> (ø) |
|
| Go | ∅ <ø> (∅) |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/core/src/segcore/phrase_match_c.cpp | 0.00% <0.00%> (ø) |
|
| internal/core/thirdparty/tantivy/phrase_match.h | 0.00% <0.00%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.