milvus
milvus copied to clipboard
enhance: improve observability in trace for segcore scalar expression [2.6]
issue: https://github.com/milvus-io/milvus/issues/44259 pr: https://github.com/milvus-io/milvus/pull/44260
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: SpadeA-Tang
To complete the pull request process, please assign zhengbuqian after the PR has been reviewed.
You can assign the PR to them by writing /assign @zhengbuqian in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
- /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]
If you have any questions or requests, please contact @zhikunyao.
[INFO] PR Label Summary by Default [SUCCESS] PR #44260 merged to master
- Title: enhance: improve observability in trace for segcore scalar expression
- Link: https://github.com/milvus-io/milvus/pull/44260
[WARNING] Milestone not set
- PR: #45823
- Title: enhance: improve observability in trace for segcore scalar expression [2.6] Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
Codecov Report
:x: Patch coverage is 94.02985% with 12 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 76.62%. Comparing base (cb08db0) to head (e3cfcd7).
:warning: Report is 277 commits behind head on 2.6.
Additional details and impacted files
@@ Coverage Diff @@
## 2.6 #45823 +/- ##
==========================================
- Coverage 76.99% 76.62% -0.37%
==========================================
Files 1700 1856 +156
Lines 262533 288062 +25529
==========================================
+ Hits 202142 220735 +18593
- Misses 53550 59979 +6429
- Partials 6841 7348 +507
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.03% <65.76%> (-0.11%) |
:arrow_down: |
| Core | 83.69% <78.28%> (+1.48%) |
:arrow_up: |
| Go | 74.62% <52.20%> (-0.77%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/core/src/exec/Driver.cpp | 82.97% <100.00%> (+0.75%) |
:arrow_up: |
| ...src/exec/expression/BinaryArithOpEvalRangeExpr.cpp | 87.03% <100.00%> (+0.18%) |
:arrow_up: |
| ...ernal/core/src/exec/expression/BinaryRangeExpr.cpp | 71.16% <100.00%> (+0.35%) |
:arrow_up: |
| internal/core/src/exec/expression/CallExpr.cpp | 100.00% <100.00%> (ø) |
|
| internal/core/src/exec/expression/ColumnExpr.cpp | 68.57% <100.00%> (+0.30%) |
:arrow_up: |
| internal/core/src/exec/expression/CompareExpr.cpp | 95.14% <100.00%> (+0.14%) |
:arrow_up: |
| internal/core/src/exec/expression/ConjunctExpr.cpp | 100.00% <100.00%> (ø) |
|
| internal/core/src/exec/expression/ExistsExpr.cpp | 60.00% <100.00%> (-0.17%) |
:arrow_down: |
| internal/core/src/exec/expression/Expr.cpp | 94.98% <100.00%> (-1.14%) |
:arrow_down: |
| ...rnal/core/src/exec/expression/JsonContainsExpr.cpp | 56.26% <100.00%> (-0.70%) |
:arrow_down: |
| ... and 24 more |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.