fix: panic when streaming coord shutdown but query coord still work
issue: #44984 pr: #45695
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
[INFO] PR Label Summary by Default [FAILED] PR #45695 not merged
- Title: fix: panic when streaming coord shutdown but query coord still work
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45695
Use /refresh-label to update related check and label manually
/lgtm
[INFO] PR Label Summary by Default [FAILED] PR #45695 not merged
- Title: fix: panic when streaming coord shutdown but query coord still work
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45695
Use /refresh-label to update related check and label manually
/ci-rerun-ut-go
Codecov Report
:x: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 76.62%. Comparing base (cb08db0) to head (23e3f4b).
:warning: Report is 258 commits behind head on 2.6.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...al/coordinator/snmanager/streaming_node_manager.go | 25.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 2.6 #45696 +/- ##
==========================================
- Coverage 76.99% 76.62% -0.37%
==========================================
Files 1700 1856 +156
Lines 262533 287706 +25173
==========================================
+ Hits 202142 220464 +18322
- Misses 53550 59905 +6355
- Partials 6841 7337 +496
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.03% <65.76%> (-0.11%) |
:arrow_down: |
| Core | 83.66% <79.17%> (+1.44%) |
:arrow_up: |
| Go | 74.65% <52.20%> (-0.74%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...al/coordinator/snmanager/streaming_node_manager.go | 78.76% <25.00%> (-2.24%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/ci-rerun-ut-integration
@chyezh cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chyezh, czs007
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[INFO] PR Label Summary by Default [FAILED] PR #45695 not merged
- Title: fix: panic when streaming coord shutdown but query coord still work
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45695
Use /refresh-label to update related check and label manually
/run-cpu-e2e
rerun go-sdk
@chyezh cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
/refresh-label
/refresh-label
[INFO] PR Label Summary by Refresh-Label
- Title: fix: panic when streaming coord shutdown but query coord still work
- Target: 2.6
- Labels: kind/bug, size/XS, approved, lgtm, ci-passed, dco-passed, do-not-merge/need-merge-master-first
[SUCCESS] PR #45695 merged to master
- Title: fix: panic when streaming coord shutdown but query coord still work
- Link: https://github.com/milvus-io/milvus/pull/45695
Use /refresh-label to update related check and label manually