milvus
milvus copied to clipboard
fix: Fix a bug that bulkimport cannot handle empty struct list
issue: https://github.com/milvus-io/milvus/issues/42148
@yhmo
Invalid PR Title Format Detected
Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
- Title Format: The PR title must begin with one of these prefixes:
feat:for introducing a new feature.fix:for bug fixes.enhance:for improvements to existing functionality.test: for add tests to existing functionality.doc: for modifying documentation.auto: for the pull request from bot.build(deps): for dependency updates from Dependabot.
- Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.
Required Title Structure:
[Type]: [Description of the PR]
Where Type is one of feat, fix, enhance, test or doc.
Example:
enhance: improve search performance significantly
Please review and update your PR to comply with these guidelines.
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
Codecov Report
:x: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 76.48%. Comparing base (aa0870d) to head (d4bdc8f).
:warning: Report is 36 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #45693 +/- ##
===========================================
- Coverage 83.19% 76.48% -6.71%
===========================================
Files 521 1875 +1354
Lines 81430 292666 +211236
===========================================
+ Hits 67744 223858 +156114
- Misses 13686 61368 +47682
- Partials 0 7440 +7440
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.17% <ø> (∅) |
|
| Core | 83.19% <93.75%> (+<0.01%) |
:arrow_up: |
| Go | 74.59% <69.59%> (∅) |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...l/util/importutilv2/parquet/struct_field_reader.go | 45.94% <100.00%> (ø) |
|
| internal/util/importutilv2/csv/row_parser.go | 75.60% <0.00%> (ø) |
|
| internal/util/importutilv2/json/row_parser.go | 81.29% <69.23%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@yhmo go-sdk check failed, comment rerun go-sdk can trigger the job again.
@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
rerun go-sdk
/run-cpu-e2e
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
@yhmo go-sdk check failed, comment rerun go-sdk can trigger the job again.
/ci-rerun-ut-integration
/ci-rerun-ut-integration
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: congqixia, yhmo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [congqixia]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment