milvus
milvus copied to clipboard
milvus-io
fix: [2.6] Fix a bug that bulkimport cannot handle empty struct list
issue: https://github.com/milvus-io/milvus/issues/42148 pr: https://github.com/milvus-io/milvus/pull/45693
@yhmo Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
@yhmo
Invalid PR Title Format Detected
Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
- Title Format: The PR title must begin with one of these prefixes:
feat:for introducing a new feature.fix:for bug fixes.enhance:for improvements to existing functionality.test: for add tests to existing functionality.doc: for modifying documentation.auto: for the pull request from bot.build(deps): for dependency updates from Dependabot.
- Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.
Required Title Structure:
[Type]: [Description of the PR]
Where Type is one of feat, fix, enhance, test or doc.
Example:
enhance: improve search performance significantly
Please review and update your PR to comply with these guidelines.
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.6' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #45692
- Title: [fix] Fix a bug that bulkimport cannot handle empty struct list Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Default [FAILED] PR #45693 not merged
- Title: fix: Fix a bug that bulkimport cannot handle empty struct list
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45693
[WARNING] Milestone not set
- PR: #45692
- Title: fix: [2.6] Fix a bug that bulkimport cannot handle empty struct list Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
Codecov Report
:x: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 76.60%. Comparing base (cb08db0) to head (0fc7ac8).
:warning: Report is 279 commits behind head on 2.6.
:x: Your patch status has failed because the patch coverage (57.89%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. :x: Your project status has failed because the head coverage (76.60%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@
## 2.6 #45692 +/- ##
==========================================
- Coverage 76.99% 76.60% -0.40%
==========================================
Files 1700 1856 +156
Lines 262533 287762 +25229
==========================================
+ Hits 202142 220426 +18284
- Misses 53550 59983 +6433
- Partials 6841 7353 +512
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.03% <65.76%> (-0.11%) |
:arrow_down: |
| Core | 83.65% <79.25%> (+1.44%) |
:arrow_up: |
| Go | 74.61% <52.20%> (-0.78%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...l/util/importutilv2/parquet/struct_field_reader.go | 44.78% <100.00%> (ø) |
|
| internal/util/importutilv2/csv/row_parser.go | 75.60% <0.00%> (-2.44%) |
:arrow_down: |
| internal/util/importutilv2/json/row_parser.go | 81.29% <69.23%> (+0.29%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@yhmo go-sdk check failed, comment rerun go-sdk can trigger the job again.
@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[INFO] PR Label Summary by Default [FAILED] PR #45693 not merged
- Title: fix: Fix a bug that bulkimport cannot handle empty struct list
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45693
[WARNING] Milestone not set
- PR: #45692
- Title: fix: [2.6] Fix a bug that bulkimport cannot handle empty struct list Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
@yhmo go-sdk check failed, comment rerun go-sdk can trigger the job again.
@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[INFO] PR Label Summary by Default [FAILED] PR #45693 not merged
- Title: fix: Fix a bug that bulkimport cannot handle empty struct list
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45693
[WARNING] Milestone not set
- PR: #45692
- Title: fix: [2.6] Fix a bug that bulkimport cannot handle empty struct list Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: congqixia, yhmo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [congqixia]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[INFO] PR Label Summary by Default [FAILED] PR #45693 not merged
- Title: fix: Fix a bug that bulkimport cannot handle empty struct list
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45693
[WARNING] Milestone not set
- PR: #45692
- Title: fix: [2.6] Fix a bug that bulkimport cannot handle empty struct list Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually