milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: [2.6] Querynode collection meta cache protection

Open yhmo opened this issue 2 weeks ago • 9 comments

issue: https://github.com/milvus-io/milvus/issues/45410 pr: https://github.com/milvus-io/milvus/pull/45531

yhmo avatar Nov 19 '25 06:11 yhmo

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yhmo To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed. You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 19 '25 06:11 sre-ci-robot

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 19 '25 06:11 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45531 not merged

  • Title: fix: Querynode collection meta cache protection
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45531

[WARNING] Milestone not set

  • PR: #45684
  • Title: fix: [2.6] Querynode collection meta cache protection Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 19 '25 06:11 sre-ci-robot

@yhmo go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 19 '25 08:11 mergify[bot]

Codecov Report

:x: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.63%. Comparing base (3203119) to head (a28fa2d). :warning: Report is 97 commits behind head on 2.6.

Files with missing lines Patch % Lines
internal/util/segcore/collection.go 70.00% 4 Missing and 2 partials :warning:

:x: Your patch check has failed because the patch coverage (76.92%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. :x: Your project check has failed because the head coverage (76.63%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.6   #45684   +/-   ##
=======================================
  Coverage   76.62%   76.63%           
=======================================
  Files        1856     1856           
  Lines      287687   287712   +25     
=======================================
+ Hits       220441   220486   +45     
+ Misses      59914    59883   -31     
- Partials     7332     7343   +11     
Components Coverage Δ
Client 78.03% <ø> (ø)
Core 83.66% <ø> (ø)
Go 74.66% <76.92%> (+0.01%) :arrow_up:
Files with missing lines Coverage Δ
internal/querynodev2/segments/collection.go 86.61% <100.00%> (+0.34%) :arrow_up:
internal/util/segcore/collection.go 50.96% <70.00%> (+3.90%) :arrow_up:

... and 34 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 19 '25 08:11 codecov[bot]

@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 19 '25 08:11 mergify[bot]

rerun go-sdk

yhmo avatar Nov 19 '25 08:11 yhmo

/run-cpu-e2e

yhmo avatar Nov 19 '25 08:11 yhmo

/ci-rerun-ut-go

yhmo avatar Nov 19 '25 09:11 yhmo

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 20 '25 05:11 sre-ci-robot