milvus
milvus copied to clipboard
enhance: QueryNodeEntitiesSize metric is inaccurate fix it
For the querynode_entity_size metric, I’m starting to feel that maybe we should abandon it. When loading a segment, the original intention was for it to measure only the memory usage of a column. However, now that some columns have indexes as well as raw data, the column itself is not actually loaded, which makes the metric meaningless. Therefore, in the future, should we consider removing this metric? After all, the memory usage of the query node can be obtained directly from the system.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: presburger
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@presburger Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
@sunby cc
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #45580
- Title: enhance: QueryNodeEntitiesSize metric is inaccurate fix it Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.06%. Comparing base (3a7a08f) to head (69232da).
:warning: Report is 77 commits behind head on 2.5.
Additional details and impacted files
@@ Coverage Diff @@
## 2.5 #45580 +/- ##
==========================================
- Coverage 82.10% 82.06% -0.04%
==========================================
Files 1128 1587 +459
Lines 179181 248687 +69506
==========================================
+ Hits 147110 204081 +56971
- Misses 26099 38604 +12505
- Partials 5972 6002 +30
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.90% <22.22%> (-0.06%) |
:arrow_down: |
| Core | 84.56% <79.63%> (∅) |
|
| Go | 82.38% <78.00%> (+0.01%) |
:arrow_up: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp | 21.37% <100.00%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.