milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: [2.5]fix rootcoord_entity_num metric bug

Open presburger opened this issue 3 weeks ago • 8 comments

#45579

presburger avatar Nov 14 '25 08:11 presburger

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: presburger To complete the pull request process, please assign liliu-z after the PR has been reviewed. You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 14 '25 08:11 sre-ci-robot

@presburger Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #")

mergify[bot] avatar Nov 14 '25 08:11 mergify[bot]

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 14 '25 08:11 sre-ci-robot

@presburger Please associate the related issue to the body of your Pull Request. (eg. "issue: #")

mergify[bot] avatar Nov 14 '25 08:11 mergify[bot]

[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found

  • Target branch '2.5' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

  • PR: #45578
  • Title: fix: fix rootcoord_entity_num metric bug Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 14 '25 08:11 sre-ci-robot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 82.06%. Comparing base (3a7a08f) to head (0670d55). :warning: Report is 77 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #45578      +/-   ##
==========================================
- Coverage   82.10%   82.06%   -0.05%     
==========================================
  Files        1128     1587     +459     
  Lines      179181   248695   +69514     
==========================================
+ Hits       147110   204080   +56970     
- Misses      26099    38608   +12509     
- Partials     5972     6007      +35     
Components Coverage Δ
Client 78.90% <22.22%> (-0.06%) :arrow_down:
Core 84.56% <79.54%> (∅)
Go 82.38% <78.18%> (+<0.01%) :arrow_up:
Files with missing lines Coverage Δ
internal/rootcoord/meta_table.go 82.63% <100.00%> (+0.04%) :arrow_up:
internal/rootcoord/quota_center.go 83.56% <100.00%> (+0.56%) :arrow_up:
pkg/metrics/rootcoord_metrics.go 100.00% <ø> (ø)

... and 511 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 14 '25 10:11 codecov[bot]

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 20 '25 05:11 sre-ci-robot

[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found

  • Target branch '2.5' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

  • PR: #45578
  • Title: fix: fix rootcoord_entity_num metric bug Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Dec 01 '25 08:12 sre-ci-robot