milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: Fix bulkimport bug for Struct field

Open yhmo opened this issue 4 weeks ago • 16 comments

issue: https://github.com/milvus-io/milvus/issues/45006

yhmo avatar Nov 11 '25 03:11 yhmo

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 11 '25 03:11 sre-ci-robot

Codecov Report

:x: Patch coverage is 27.64228% with 89 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.60%. Comparing base (dcf4906) to head (101c610). :warning: Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
...l/util/importutilv2/parquet/struct_field_reader.go 6.06% 61 Missing and 1 partial :warning:
internal/util/importutilv2/csv/row_parser.go 53.57% 18 Missing and 8 partials :warning:
internal/util/testutil/test_util.go 0.00% 1 Missing :warning:

:x: Your patch status has failed because the patch coverage (27.64%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. :x: Your project status has failed because the head coverage (76.60%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45474      +/-   ##
==========================================
+ Coverage   73.94%   76.60%   +2.66%     
==========================================
  Files        1347     1865     +518     
  Lines      209267   290164   +80897     
==========================================
+ Hits       154735   222288   +67553     
- Misses      47165    60505   +13340     
- Partials     7367     7371       +4     
Components Coverage Δ
Client 78.17% <ø> (ø)
Core 83.58% <ø> (∅)
Go 74.61% <27.64%> (-0.03%) :arrow_down:
Files with missing lines Coverage Δ
internal/util/testutil/test_util.go 64.78% <0.00%> (+0.55%) :arrow_up:
internal/util/importutilv2/csv/row_parser.go 76.10% <53.57%> (-0.84%) :arrow_down:
...l/util/importutilv2/parquet/struct_field_reader.go 45.21% <6.06%> (-11.72%) :arrow_down:

... and 533 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 11 '25 05:11 codecov[bot]

@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 11 '25 06:11 mergify[bot]

/run-cpu-e2e

yhmo avatar Nov 11 '25 06:11 yhmo

/ci-rerun-ut-integration

yhmo avatar Nov 11 '25 06:11 yhmo

/ci-rerun-ut-integration

yhmo avatar Nov 11 '25 07:11 yhmo

@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 11 '25 09:11 mergify[bot]

@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 11 '25 15:11 mergify[bot]

/run-cpu-e2e

yhmo avatar Nov 12 '25 02:11 yhmo

@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 12 '25 05:11 mergify[bot]

/run-cpu-e2e

yhmo avatar Nov 12 '25 06:11 yhmo

@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 12 '25 08:11 mergify[bot]

/run-cpu-e2e

yhmo avatar Nov 12 '25 10:11 yhmo

@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 12 '25 11:11 mergify[bot]

/run-cpu-e2e

yhmo avatar Nov 12 '25 11:11 yhmo

/lgtm

SpadeA-Tang avatar Nov 13 '25 03:11 SpadeA-Tang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 13 '25 03:11 sre-ci-robot