milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: remove validateFieldName in dropIndex [2.6]

Open SpadeA-Tang opened this issue 3 weeks ago • 9 comments

issue: https://github.com/milvus-io/milvus/issues/45459 pr: https://github.com/milvus-io/milvus/pull/45460

SpadeA-Tang avatar Nov 10 '25 11:11 SpadeA-Tang

[INFO] PR Label Summary by Default [FAILED] PR #45460 not merged

  • Title: fix: remove validateFieldName in dropIndex
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45460

[WARNING] Milestone not set

  • PR: #45462
  • Title: fix: remove validateFieldName in dropIndex [2.6] Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 10 '25 11:11 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45460 not merged

  • Title: fix: remove validateFieldName in dropIndex
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45460

[WARNING] Milestone not set

  • PR: #45462
  • Title: fix: remove validateFieldName in dropIndex [2.6] Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 10 '25 11:11 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45460 not merged

  • Title: fix: remove validateFieldName in dropIndex
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45460

[WARNING] Milestone not set

  • PR: #45462
  • Title: fix: remove validateFieldName in dropIndex [2.6] Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 10 '25 11:11 sre-ci-robot

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 10 '25 11:11 sre-ci-robot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 76.66%. Comparing base (cb08db0) to head (26847d2). :warning: Report is 243 commits behind head on 2.6.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #45462      +/-   ##
==========================================
- Coverage   76.99%   76.66%   -0.34%     
==========================================
  Files        1700     1852     +152     
  Lines      262533   286887   +24354     
==========================================
+ Hits       202142   219931   +17789     
- Misses      53550    59625    +6075     
- Partials     6841     7331     +490     
Components Coverage Δ
Client 78.03% <65.76%> (-0.11%) :arrow_down:
Core 83.89% <78.94%> (+1.67%) :arrow_up:
Go 74.61% <52.39%> (-0.78%) :arrow_down:
Files with missing lines Coverage Δ
internal/proxy/task_index.go 73.85% <ø> (+1.14%) :arrow_up:

... and 607 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 10 '25 13:11 codecov[bot]

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 10 '25 16:11 mergify[bot]

/run-cpu-e2e

SpadeA-Tang avatar Nov 13 '25 06:11 SpadeA-Tang

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 13 '25 10:11 mergify[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SpadeA-Tang, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 14 '25 02:11 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45460 not merged

  • Title: fix: remove validateFieldName in dropIndex
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45460

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 14 '25 02:11 sre-ci-robot

/lgtm

xiaocai2333 avatar Nov 14 '25 02:11 xiaocai2333

[INFO] PR Label Summary by Default [SUCCESS] PR #45460 merged to master

  • Title: fix: remove validateFieldName in dropIndex
  • Link: https://github.com/milvus-io/milvus/pull/45460

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 14 '25 02:11 sre-ci-robot

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 14 '25 03:11 mergify[bot]

/run-cpu-e2e

SpadeA-Tang avatar Nov 14 '25 03:11 SpadeA-Tang

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 14 '25 03:11 mergify[bot]