milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: optimize pk search to use binary search, and 2 pointers for in expr

Open zhengbuqian opened this issue 3 weeks ago • 16 comments

issue: #44935

this is somewhat related to #44935, but on pk instead of stl_sort index

zhengbuqian avatar Nov 05 '25 14:11 zhengbuqian

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 05 '25 14:11 sre-ci-robot

@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 05 '25 15:11 mergify[bot]

Codecov Report

:x: Patch coverage is 77.60000% with 28 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.48%. Comparing base (96d0e78) to head (3319050). :warning: Report is 39 commits behind head on master.

Files with missing lines Patch % Lines
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 76.99% 26 Missing :warning:
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 83.33% 2 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45328      +/-   ##
==========================================
- Coverage   76.55%   76.48%   -0.07%     
==========================================
  Files        1875     1875              
  Lines      291983   291980       -3     
==========================================
- Hits       223531   223326     -205     
- Misses      61073    61244     +171     
- Partials     7379     7410      +31     
Components Coverage Δ
Client 78.17% <ø> (ø)
Core 83.18% <77.60%> (-0.01%) :arrow_down:
Go 74.59% <ø> (-0.11%) :arrow_down:
Files with missing lines Coverage Δ
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 64.61% <83.33%> (-0.14%) :arrow_down:
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 76.40% <76.99%> (+1.01%) :arrow_up:

... and 37 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 05 '25 15:11 codecov[bot]

rerun go-sdk

zhengbuqian avatar Nov 06 '25 03:11 zhengbuqian

@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 06 '25 05:11 mergify[bot]

rerun go-sdk

zhengbuqian avatar Nov 06 '25 09:11 zhengbuqian

@zhengbuqian cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 07 '25 10:11 mergify[bot]

@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 07 '25 10:11 mergify[bot]

@zhengbuqian cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 12 '25 06:11 mergify[bot]

/ci-rerun-ut-go

zhengbuqian avatar Nov 12 '25 06:11 zhengbuqian

/run-cpu-e2e

zhengbuqian avatar Nov 12 '25 06:11 zhengbuqian

/ci-rerun-ut-integration

zhengbuqian avatar Nov 17 '25 08:11 zhengbuqian

/ci-rerun-ut-integration

zhengbuqian avatar Nov 17 '25 09:11 zhengbuqian

/hold

zhengbuqian avatar Nov 18 '25 07:11 zhengbuqian

/unhold

zhengbuqian avatar Nov 18 '25 13:11 zhengbuqian

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 21 '25 11:11 sre-ci-robot