milvus
milvus copied to clipboard
enhance: optimize the sni configuration for grpc tls in Milvus
issue: #45289
@presburger Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #
@presburger
Invalid PR Title Format Detected
Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
- Title Format: The PR title must begin with one of these prefixes:
feat:for introducing a new feature.fix:for bug fixes.enhance:for improvements to existing functionality.test: for add tests to existing functionality.doc: for modifying documentation.auto: for the pull request from bot.build(deps): for dependency updates from Dependabot.
- Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.
Required Title Structure:
[Type]: [Description of the PR]
Where Type is one of feat, fix, enhance, test or doc.
Example:
enhance: improve search performance significantly
Please review and update your PR to comply with these guidelines.
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #45288
- Title: enhance: Optimize the SNI configuration for gRPC TLS in Milvus Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
Codecov Report
:x: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.24%. Comparing base (3a7a08f) to head (fd946a6).
:warning: Report is 77 commits behind head on 2.5.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/distributed/utils/util.go | 63.63% | 2 Missing and 2 partials :warning: |
:x: Your project check has failed because the head coverage (58.24%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@
## 2.5 #45288 +/- ##
===========================================
- Coverage 82.10% 58.24% -23.86%
===========================================
Files 1128 1468 +340
Lines 179181 238274 +59093
===========================================
- Hits 147110 138789 -8321
- Misses 26099 92452 +66353
- Partials 5972 7033 +1061
| Components | Coverage Δ | |
|---|---|---|
| Client | ∅ <ø> (∅) |
|
| Core | 84.56% <79.54%> (∅) |
|
| Go | 47.86% <60.93%> (-34.51%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/distributed/indexnode/client/client.go | 58.87% <100.00%> (-26.56%) |
:arrow_down: |
| internal/rootcoord/meta_table.go | 47.43% <100.00%> (-35.17%) |
:arrow_down: |
| internal/rootcoord/quota_center.go | 54.72% <100.00%> (-28.28%) |
:arrow_down: |
| pkg/metrics/rootcoord_metrics.go | 18.51% <ø> (-81.49%) |
:arrow_down: |
| internal/distributed/utils/util.go | 64.78% <63.63%> (-5.22%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #45288
- Title: enhance: optimize the sni configuration for grpc tls in Milvus Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
@presburger cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
@presburger cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
@presburger cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: presburger
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #45288
- Title: enhance: optimize the sni configuration for grpc tls in Milvus Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually