milvus icon indicating copy to clipboard operation
milvus copied to clipboard

feat: Support zilliz models

Open junjiejiangjjj opened this issue 1 month ago • 19 comments

https://github.com/milvus-io/milvus/issues/35856

junjiejiangjjj avatar Oct 30 '25 07:10 junjiejiangjjj

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Oct 30 '25 07:10 sre-ci-robot

Codecov Report

:x: Patch coverage is 80.66298% with 70 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.64%. Comparing base (dcf4906) to head (e1c4601). :warning: Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
...il/function/embedding/zilliz_embedding_provider.go 42.85% 28 Missing :warning:
...ernal/util/function/models/zilliz/zilliz_client.go 84.17% 18 Missing and 7 partials :warning:
...ernal/util/function/embedding/function_executor.go 63.63% 3 Missing and 1 partial :warning:
...util/function/embedding/text_embedding_function.go 80.00% 4 Missing :warning:
internal/proxy/task_search.go 50.00% 0 Missing and 2 partials :warning:
internal/util/function/models/common.go 87.50% 2 Missing :warning:
internal/util/function/rerank/function_score.go 60.00% 1 Missing and 1 partial :warning:
...nal/util/function/rerank/zilliz_rerank_provider.go 92.59% 2 Missing :warning:
internal/datanode/importv2/util.go 83.33% 0 Missing and 1 partial :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45168      +/-   ##
==========================================
+ Coverage   73.94%   76.64%   +2.70%     
==========================================
  Files        1347     1868     +521     
  Lines      209267   290384   +81117     
==========================================
+ Hits       154735   222566   +67831     
- Misses      47165    60452   +13287     
+ Partials     7367     7366       -1     
Components Coverage Δ
Client 78.17% <ø> (ø)
Core 83.58% <ø> (∅)
Go 74.67% <80.66%> (+0.02%) :arrow_up:
Files with missing lines Coverage Δ
internal/datacoord/import_util.go 77.60% <100.00%> (+0.03%) :arrow_up:
internal/proxy/util.go 80.41% <100.00%> (ø)
.../util/function/embedding/ali_embedding_provider.go 81.92% <100.00%> (+0.22%) :arrow_up:
...l/function/embedding/bedrock_embedding_provider.go 82.08% <100.00%> (+0.13%) :arrow_up:
...il/function/embedding/cohere_embedding_provider.go 85.00% <100.00%> (+0.15%) :arrow_up:
internal/util/function/embedding/function_util.go 86.66% <ø> (ø)
...il/function/embedding/openai_embedding_provider.go 78.09% <100.00%> (+0.21%) :arrow_up:
...nction/embedding/siliconflow_embedding_provider.go 79.66% <100.00%> (+0.35%) :arrow_up:
.../util/function/embedding/tei_embedding_provider.go 86.04% <100.00%> (+0.16%) :arrow_up:
.../function/embedding/vertexai_embedding_provider.go 75.83% <100.00%> (+0.16%) :arrow_up:
... and 18 more

... and 540 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 30 '25 08:10 codecov[bot]

@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 30 '25 13:10 mergify[bot]

/run-cpu-e2e

junjiejiangjjj avatar Oct 30 '25 13:10 junjiejiangjjj

@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 30 '25 16:10 mergify[bot]

/run-cpu-e2e

junjiejiangjjj avatar Oct 31 '25 02:10 junjiejiangjjj

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Oct 31 '25 04:10 mergify[bot]

@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 31 '25 06:10 mergify[bot]

@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 31 '25 08:10 mergify[bot]

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Oct 31 '25 09:10 mergify[bot]

/run-cpu-e2e

junjiejiangjjj avatar Nov 01 '25 15:11 junjiejiangjjj

rerun go-sdk

junjiejiangjjj avatar Nov 01 '25 15:11 junjiejiangjjj

@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 06 '25 12:11 mergify[bot]

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 06 '25 12:11 mergify[bot]

@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 07 '25 11:11 mergify[bot]

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 07 '25 12:11 mergify[bot]

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 11 '25 05:11 mergify[bot]

rerun go-sdk

junjiejiangjjj avatar Nov 11 '25 06:11 junjiejiangjjj

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: junjiejiangjjj, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 13 '25 04:11 sre-ci-robot