milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: convert jsonstats translator to bson_index translator

Open zhagnlu opened this issue 1 month ago • 6 comments

zhagnlu avatar Oct 22 '25 09:10 zhagnlu

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed. You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Oct 22 '25 09:10 sre-ci-robot

@zhagnlu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Oct 22 '25 09:10 mergify[bot]

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Oct 22 '25 09:10 sre-ci-robot

@zhagnlu Please associate the related issue to the body of your Pull Request. (eg. "issue: #")

mergify[bot] avatar Oct 22 '25 09:10 mergify[bot]

/ci-rerun-ut-cpp

zhagnlu avatar Oct 22 '25 11:10 zhagnlu

Codecov Report

:x: Patch coverage is 58.20896% with 84 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.95%. Comparing base (7078f40) to head (f2212db). :warning: Report is 4 commits behind head on master.

:warning: Current head f2212db differs from pull request most recent head 36e16a0

Please upload reports for the commit 36e16a0 to get more accurate results.

Files with missing lines Patch % Lines
...rnal/core/src/exec/expression/JsonContainsExpr.cpp 10.00% 27 Missing :warning:
internal/core/src/segcore/segment_c.cpp 0.00% 12 Missing :warning:
internal/core/src/exec/expression/TermExpr.cpp 0.00% 6 Missing :warning:
internal/core/src/exec/expression/UnaryExpr.cpp 0.00% 6 Missing :warning:
...ernal/core/src/exec/expression/BinaryRangeExpr.cpp 0.00% 5 Missing :warning:
internal/core/src/segcore/SegmentInterface.cpp 0.00% 5 Missing :warning:
internal/core/src/storage/DiskFileManagerImpl.cpp 0.00% 5 Missing :warning:
...e/unittest/test_json_stats/test_json_key_stats.cpp 58.33% 5 Missing :warning:
internal/core/src/exec/expression/ExistsExpr.cpp 0.00% 4 Missing :warning:
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 60.00% 4 Missing :warning:
... and 3 more

:x: Your project check has failed because the head coverage (76.95%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45036      +/-   ##
==========================================
+ Coverage   76.26%   76.95%   +0.69%     
==========================================
  Files        1878     1833      -45     
  Lines      293457   285359    -8098     
==========================================
- Hits       223802   219608    -4194     
+ Misses      62220    58556    -3664     
+ Partials     7435     7195     -240     
Components Coverage Δ
Client 78.03% <ø> (-0.15%) :arrow_down:
Core 83.84% <58.20%> (+0.68%) :arrow_up:
Go 75.08% <ø> (+0.79%) :arrow_up:
Files with missing lines Coverage Δ
...nternal/core/src/exec/expression/BinaryRangeExpr.h 91.66% <ø> (ø)
internal/core/src/exec/expression/ExistsExpr.h 45.45% <ø> (ø)
internal/core/src/exec/expression/Expr.h 69.49% <100.00%> (+1.38%) :arrow_up:
...re/src/exec/expression/JsonContainsByStatsTest.cpp 100.00% <100.00%> (ø)
...ternal/core/src/exec/expression/JsonContainsExpr.h 9.13% <ø> (ø)
internal/core/src/exec/expression/TermExpr.h 83.33% <ø> (ø)
internal/core/src/exec/expression/UnaryExpr.h 45.88% <ø> (ø)
...nternal/core/src/index/json_stats/JsonKeyStats.cpp 87.34% <100.00%> (+0.75%) :arrow_up:
internal/core/src/index/json_stats/bson_inverted.h 100.00% <100.00%> (ø)
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 71.77% <100.00%> (+7.54%) :arrow_up:
... and 18 more

... and 468 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 22 '25 11:10 codecov[bot]