fix: diskann no longer forcibly overrides parameters.

[presburger]

issue: #44445

[mergify[bot]]

@presburger Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #")

[mergify[bot]]

@presburger

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

1. Title Format: The PR title must begin with one of these prefixes:

• feat: for introducing a new feature.
• fix: for bug fixes.
• enhance: for improvements to existing functionality.
• test: for add tests to existing functionality.
• doc: for modifying documentation.
• auto: for the pull request from bot.
• build(deps): for dependency updates from Dependabot.

2. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

[sre-ci-robot]

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

• Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
• Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
• For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

• /ci-rerun-build // for ci-v2/build
• /ci-rerun-ut-integration // for ci-v2/ut-integration
• /ci-rerun-ut-go // for ci-v2/ut-go
• /ci-rerun-ut-cpp // for ci-v2/ut-cpp
• /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp

If you have any questions or requests, please contact @zhikunyao.

[sre-ci-robot]

[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found

• Target branch '2.5' requires a PR merged to master first
• Please add reference in format 'pr: #number'

[WARNING] Milestone not set

• PR: #44444
• Title: bug: diskann no longer forcibly overrides parameters. Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

[mergify[bot]]

@presburger Please associate the related issue to the body of your Pull Request. (eg. "issue: #")

[xiaofan-luan]

/lgtm /approve

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: presburger, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~pkg/util/OWNERS~~ [xiaofan-luan]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[sre-ci-robot]

[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found

• Target branch '2.5' requires a PR merged to master first
• Please add reference in format 'pr: #number'

[WARNING] Milestone not set

• PR: #44444
• Title: fix: diskann no longer forcibly overrides parameters. Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

[codecov[bot]]

Codecov Report

:x: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.27%. Comparing base (3a7a08f) to head (d066eae). :warning: Report is 77 commits behind head on 2.5.

Files with missing lines	Patch %	Lines
pkg/util/indexparams/index_params.go	0.00%	12 Missing :warning:

:x: Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. :x: Your project check has failed because the head coverage (58.27%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##              2.5   #44444       +/-   ##
===========================================
- Coverage   82.10%   58.27%   -23.83%     
===========================================
  Files        1128     1469      +341     
  Lines      179181   238187    +59006     
===========================================
- Hits       147110   138806     -8304     
- Misses      26099    92351    +66252     
- Partials     5972     7030     +1058     

Components	Coverage Δ
Client	∅ <ø> (∅)
Core	84.65% <78.12%> (∅)
Go	47.87% <62.18%> (-34.50%)	:arrow_down:

Files with missing lines	Coverage Δ
pkg/util/indexparams/index_params.go	2.64% <0.00%> (-83.46%)	:arrow_down:

... and 1322 files with indirect coverage changes

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[yanliang567]

i don't think we need this PR accoridng to the doc @presburger @xiaofan-luan https://milvus.io/docs/diskann.md#DISKANN

[xiaofan-luan]

@presburger seems that we need to fix the ut in golang and resubmit

[sre-ci-robot]

[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found

• Target branch '2.5' requires a PR merged to master first
• Please add reference in format 'pr: #number'

[WARNING] Milestone not set

• PR: #44444
• Title: fix: diskann no longer forcibly overrides parameters. Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

[sre-ci-robot]

[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found

• Target branch '2.5' requires a PR merged to master first
• Please add reference in format 'pr: #number'

[WARNING] Milestone not set

• PR: #44444
• Title: fix: diskann no longer forcibly overrides parameters. Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

[sre-ci-robot]

New changes are detected. LGTM label has been removed.

[sre-ci-robot]

[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found

• Target branch '2.5' requires a PR merged to master first
• Please add reference in format 'pr: #number'

[WARNING] Milestone not set

• PR: #44444
• Title: fix: diskann no longer forcibly overrides parameters. Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

[xiaofan-luan]

/ci-rerun-ut-go

[xiaofan-luan]

@presburger we need a fix for master and branch 2.6 as well