milvus
milvus copied to clipboard
fix: fix build issue on macos (#44038)
issue: #44038
Welcome @xinxinsh! It looks like this is your first PR to milvus-io/milvus 🎉
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: xinxinsh
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut // for both ci-v2/ut-integration and ci-v2/ut-go
If you have any questions or requests, please contact @zhikunyao.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 73.59%. Comparing base (7f470e6) to head (f24566c).
:warning: Report is 494 commits behind head on master.
:x: Your project check has failed because the head coverage (73.59%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@
## master #44044 +/- ##
===========================================
- Coverage 75.96% 73.59% -2.37%
===========================================
Files 1579 344 -1235
Lines 229032 33496 -195536
===========================================
- Hits 173980 24652 -149328
+ Misses 48441 8844 -39597
+ Partials 6611 0 -6611
| Components | Coverage Δ | |
|---|---|---|
| Client | ∅ <ø> (∅) |
|
| Core | 73.59% <ø> (ø) |
|
| Go | ∅ <ø> (∅) |
|
| see 1235 files with indirect coverage changes |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@xinxinsh cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
@yanliang567 could you help review this pr
@liliu-z please help to take a review
@liliu-z pls take a review
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
@xinxinsh do you mind to resubmit this issue? CIs failed caused by recent CI upgrading