milvus
milvus copied to clipboard
fix: filter new proxy when initializing proxy session at timeticksync
issue: #40532
Codecov Report
Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
Project coverage is 80.56%. Comparing base (
80f1d70) to head (da7f560). Report is 12 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/rootcoord/timeticksync.go | 14.28% | 5 Missing and 1 partial :warning: |
:x: Your patch status has failed because the patch coverage (14.28%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@
## master #42831 +/- ##
=======================================
Coverage 80.55% 80.56%
=======================================
Files 1552 1552
Lines 221189 221199 +10
=======================================
+ Hits 178172 178200 +28
+ Misses 36640 36626 -14
+ Partials 6377 6373 -4
| Components | Coverage Δ | |
|---|---|---|
| Client | 79.25% <ø> (ø) |
|
| Core | 72.78% <ø> (+0.01%) |
:arrow_up: |
| Go | 82.11% <14.28%> (+<0.01%) |
:arrow_up: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/rootcoord/timeticksync.go | 85.61% <14.28%> (-3.36%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chyezh, czs007
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/rootcoord/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment