milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: Remove cached null expr result

Open sunby opened this issue 5 months ago • 11 comments
trafficstars

pr: https://github.com/milvus-io/milvus/pull/42818 issue: #42698 cached result may be changed in caller so there is no need to cache it

sunby avatar Jun 16 '25 09:06 sunby

@sunby Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

mergify[bot] avatar Jun 16 '25 09:06 mergify[bot]

[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found

  • Target branch '2.5' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

  • PR: #42783
  • Title: fix: Remove cached null expr result Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Jun 16 '25 09:06 sre-ci-robot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.59%. Comparing base (3915eca) to head (2e3a05b). Report is 33 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #42783      +/-   ##
==========================================
- Coverage   80.67%   80.59%   -0.08%     
==========================================
  Files        1430     1431       +1     
  Lines      206004   207120    +1116     
==========================================
+ Hits       166191   166927     +736     
- Misses      33984    34329     +345     
- Partials     5829     5864      +35     
Components Coverage Δ
Client 79.42% <ø> (ø)
Core 70.40% <100.00%> (-0.31%) :arrow_down:
Go 82.62% <ø> (-0.02%) :arrow_down:
Files with missing lines Coverage Δ
internal/core/src/exec/expression/NullExpr.cpp 91.42% <100.00%> (+1.01%) :arrow_up:
internal/core/src/exec/expression/NullExpr.h 45.45% <ø> (ø)

... and 62 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 16 '25 11:06 codecov[bot]

/lgtm /approve

xiaofan-luan avatar Jun 16 '25 18:06 xiaofan-luan

[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found

  • Target branch '2.5' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

  • PR: #42783
  • Title: fix: Remove cached null expr result Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Jun 16 '25 18:06 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #42818 not merged

  • Title: fix: Remove cached null expr result
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/42818

[WARNING] Milestone not set

  • PR: #42783
  • Title: fix: Remove cached null expr result Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Jun 17 '25 09:06 sre-ci-robot

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Jun 17 '25 12:06 mergify[bot]

rerun cpp-unit-test

sunby avatar Jun 18 '25 02:06 sunby

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Jun 18 '25 06:06 mergify[bot]

rerun cpp-unit-test

sunby avatar Jun 18 '25 10:06 sunby

/lgtm

zhagnlu avatar Jun 23 '25 07:06 zhagnlu

/approve

zhengbuqian avatar Jun 23 '25 08:06 zhengbuqian

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunby, xiaofan-luan, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jun 23 '25 08:06 sre-ci-robot

[INFO] PR Label Summary by Default [SUCCESS] PR #42818 merged to master

  • Title: fix: Remove cached null expr result
  • Link: https://github.com/milvus-io/milvus/pull/42818

[WARNING] Milestone not set

  • PR: #42783
  • Title: fix: Remove cached null expr result Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Jun 23 '25 08:06 sre-ci-robot