milvus
milvus copied to clipboard
fix: Remove cached null expr result
pr: https://github.com/milvus-io/milvus/pull/42818 issue: #42698 cached result may be changed in caller so there is no need to cache it
@sunby Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #42783
- Title: fix: Remove cached null expr result Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 80.59%. Comparing base (
3915eca) to head (2e3a05b). Report is 33 commits behind head on 2.5.
Additional details and impacted files
@@ Coverage Diff @@
## 2.5 #42783 +/- ##
==========================================
- Coverage 80.67% 80.59% -0.08%
==========================================
Files 1430 1431 +1
Lines 206004 207120 +1116
==========================================
+ Hits 166191 166927 +736
- Misses 33984 34329 +345
- Partials 5829 5864 +35
| Components | Coverage Δ | |
|---|---|---|
| Client | 79.42% <ø> (ø) |
|
| Core | 70.40% <100.00%> (-0.31%) |
:arrow_down: |
| Go | 82.62% <ø> (-0.02%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/core/src/exec/expression/NullExpr.cpp | 91.42% <100.00%> (+1.01%) |
:arrow_up: |
| internal/core/src/exec/expression/NullExpr.h | 45.45% <ø> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/lgtm /approve
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #42783
- Title: fix: Remove cached null expr result Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Default [FAILED] PR #42818 not merged
- Title: fix: Remove cached null expr result
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/42818
[WARNING] Milestone not set
- PR: #42783
- Title: fix: Remove cached null expr result Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.
rerun cpp-unit-test
@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.
rerun cpp-unit-test
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sunby, xiaofan-luan, zhengbuqian
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/core/OWNERS~~ [xiaofan-luan,zhengbuqian]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[INFO] PR Label Summary by Default [SUCCESS] PR #42818 merged to master
- Title: fix: Remove cached null expr result
- Link: https://github.com/milvus-io/milvus/pull/42818
[WARNING] Milestone not set
- PR: #42783
- Title: fix: Remove cached null expr result Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually