milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: bulkinsert handle nullable fields for numpy file

Open yhmo opened this issue 5 months ago • 6 comments

issue: https://github.com/milvus-io/milvus/issues/42173

yhmo avatar Jun 16 '25 03:06 yhmo

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yhmo To complete the pull request process, please assign czs007 after the PR has been reviewed. You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jun 16 '25 03:06 sre-ci-robot

@yhmo Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar Jun 16 '25 03:06 mergify[bot]

Codecov Report

Attention: Patch coverage is 88.34586% with 31 lines in your changes missing coverage. Please review.

Project coverage is 80.78%. Comparing base (24e24ca) to head (198dde9). Report is 18 commits behind head on master.

:exclamation: Current head 198dde9 differs from pull request most recent head b44be55

Please upload reports for the commit b44be55 to get more accurate results.

Files with missing lines Patch % Lines
internal/util/importutilv2/csv/row_parser.go 84.93% 9 Missing and 2 partials :warning:
internal/util/importutilv2/numpy/field_reader.go 70.58% 10 Missing :warning:
internal/util/importutilv2/json/row_parser.go 85.48% 8 Missing and 1 partial :warning:
internal/util/importutilv2/parquet/util.go 87.50% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #42771       +/-   ##
===========================================
+ Coverage   72.79%   80.78%    +7.98%     
===========================================
  Files         341     1551     +1210     
  Lines       31945   221266   +189321     
===========================================
+ Hits        23255   178748   +155493     
- Misses       8690    36281    +27591     
- Partials        0     6237     +6237     
Components Coverage Δ
Client 79.25% <ø> (∅)
Core 72.88% <ø> (+0.09%) :arrow_up:
Go 82.36% <88.34%> (∅)
Files with missing lines Coverage Δ
internal/util/importutilv2/binlog/reader.go 62.77% <100.00%> (ø)
internal/util/importutilv2/binlog/util.go 71.11% <100.00%> (ø)
internal/util/importutilv2/numpy/reader.go 63.07% <100.00%> (ø)
internal/util/importutilv2/numpy/util.go 76.52% <100.00%> (ø)
internal/util/importutilv2/parquet/reader.go 62.79% <100.00%> (ø)
internal/util/testutil/test_util.go 90.56% <100.00%> (ø)
internal/util/importutilv2/parquet/util.go 81.81% <87.50%> (ø)
internal/util/importutilv2/json/row_parser.go 88.15% <85.48%> (ø)
internal/util/importutilv2/numpy/field_reader.go 74.71% <70.58%> (ø)
internal/util/importutilv2/csv/row_parser.go 87.52% <84.93%> (ø)

... and 1219 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 16 '25 05:06 codecov[bot]

@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 17 '25 09:06 mergify[bot]

@yhmo cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Jun 17 '25 12:06 mergify[bot]

@yhmo cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Jun 18 '25 14:06 mergify[bot]

@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 19 '25 10:06 mergify[bot]

@yhmo go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Jun 19 '25 10:06 mergify[bot]

@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 24 '25 07:06 mergify[bot]

@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 24 '25 08:06 mergify[bot]

@yhmo cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Jun 24 '25 14:06 mergify[bot]

@yhmo go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Jun 25 '25 04:06 mergify[bot]

@yhmo cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 25 '25 05:06 mergify[bot]

/run-cpu-e2e

yhmo avatar Jun 25 '25 06:06 yhmo