milvus
milvus copied to clipboard
feat: impl StructArray -- data storage support in go
Ref https://github.com/milvus-io/milvus/issues/42148
This PR enables go part storage to support array of vector type.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: SpadeA-Tang
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
Codecov Report
Attention: Patch coverage is 56.09137% with 173 lines in your changes missing coverage. Please review.
Project coverage is 80.48%. Comparing base (
d35c33d) to head (3220abe). Report is 28 commits behind head on master.
:x: Your patch status has failed because the patch coverage (56.09%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@
## master #42453 +/- ##
==========================================
- Coverage 81.81% 80.48% -1.33%
==========================================
Files 1211 1552 +341
Lines 189086 221307 +32221
==========================================
+ Hits 154704 178128 +23424
- Misses 28001 36777 +8776
- Partials 6381 6402 +21
| Components | Coverage Δ | |
|---|---|---|
| Client | 79.47% <ø> (ø) |
|
| Core | 72.78% <ø> (∅) |
|
| Go | 82.01% <56.09%> (-0.04%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...nternal/datanode/compactor/clustering_compactor.go | 64.86% <100.00%> (ø) |
|
| internal/datanode/compactor/segment_writer.go | 64.77% <100.00%> (-0.90%) |
:arrow_down: |
| internal/storage/data_sorter.go | 90.00% <100.00%> (+0.89%) |
:arrow_up: |
| internal/util/importutilv2/binlog/reader.go | 55.37% <100.00%> (ø) |
|
| internal/flushcommon/syncmgr/pack_writer_v2.go | 76.66% <50.00%> (ø) |
|
| internal/storage/serde_events_v2.go | 75.13% <60.00%> (+1.60%) |
:arrow_up: |
| internal/storage/arrow_util.go | 53.44% <62.50%> (-0.28%) |
:arrow_down: |
| internal/storage/schema.go | 84.61% <78.94%> (-3.39%) |
:arrow_down: |
| internal/storage/payload_reader.go | 68.29% <62.50%> (-0.16%) |
:arrow_down: |
| internal/storage/payload_writer.go | 89.75% <60.86%> (-1.07%) |
:arrow_down: |
| ... and 5 more |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@SpadeA-Tang let me know if the PR is ready to be reviewed.
@SpadeA-Tang let me know if the PR is ready to be reviewed.
Yes
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
@SpadeA-Tang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.
@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
rerun go-sdk
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
@SpadeA-Tang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.
@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
rerun go-sdk
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
rerun go-sdk
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
rerun go-sdk
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.
@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.