milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: incorrect dim set when creating BM25 doc sparse array

Open zhengbuqian opened this issue 1 year ago • 5 comments

zhengbuqian avatar Nov 15 '24 08:11 zhengbuqian

@zhengbuqian Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar Nov 15 '24 08:11 mergify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.62%. Comparing base (5a23c80) to head (f432d3b). Report is 16 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37717      +/-   ##
==========================================
- Coverage   80.67%   80.62%   -0.06%     
==========================================
  Files        1357     1357              
  Lines      190679   190938     +259     
==========================================
+ Hits       153835   153940     +105     
- Misses      31416    31571     +155     
+ Partials     5428     5427       -1     
Components Coverage Δ
Client 61.25% <ø> (ø)
Core 68.58% <ø> (-0.36%) :arrow_down:
Go 83.19% <100.00%> (+<0.01%) :arrow_up:
Files with missing lines Coverage Δ
internal/storage/stats.go 66.46% <100.00%> (ø)
internal/util/function/bm25_function.go 80.39% <100.00%> (+0.39%) :arrow_up:

... and 38 files with indirect coverage changes

codecov[bot] avatar Nov 15 '24 10:11 codecov[bot]

/lgtm

aoiasd avatar Nov 15 '24 11:11 aoiasd

/approve

czs007 avatar Nov 16 '24 01:11 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 16 '24 01:11 sre-ci-robot

issue: #35853

zhengbuqian avatar Nov 16 '24 06:11 zhengbuqian