milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: remove collection queryable check from health check

Open jaime0815 opened this issue 1 year ago • 4 comments

jaime0815 avatar Nov 15 '24 06:11 jaime0815

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.67%. Comparing base (caf207f) to head (00780a6). Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
internal/querycoordv2/services.go 0.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37712       +/-   ##
===========================================
+ Coverage   68.07%   80.67%   +12.60%     
===========================================
  Files         290     1357     +1067     
  Lines       25455   190680   +165225     
===========================================
+ Hits        17328   153830   +136502     
- Misses       8127    31417    +23290     
- Partials        0     5433     +5433     
Components Coverage Δ
Client 61.25% <ø> (∅)
Core 68.92% <ø> (+0.84%) :arrow_up:
Go 83.18% <0.00%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/services.go 87.07% <0.00%> (ø)

... and 1075 files with indirect coverage changes

codecov[bot] avatar Nov 15 '24 08:11 codecov[bot]

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 15 '24 08:11 mergify[bot]

/run-cpu-e2e

jaime0815 avatar Nov 15 '24 09:11 jaime0815

/approve /lgtm

czs007 avatar Nov 18 '24 02:11 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 18 '24 02:11 sre-ci-robot