milvus
milvus copied to clipboard
enhance: Reduce GetIndexInfos calls
Batch GetIndexInfos calls for segments to reduce RPC calls.
issue: https://github.com/milvus-io/milvus/issues/37634
@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
Codecov Report
Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.
Project coverage is 80.67%. Comparing base (
4820dd7) to head (b3cbe49). Report is 36 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/querycoordv2/meta/coordinator_broker.go | 91.30% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #37695 +/- ##
==========================================
- Coverage 80.67% 80.67% -0.01%
==========================================
Files 1357 1357
Lines 190739 190736 -3
==========================================
- Hits 153883 153874 -9
- Misses 31428 31429 +1
- Partials 5428 5433 +5
| Components | Coverage Δ | |
|---|---|---|
| Client | 61.25% <ø> (ø) |
|
| Core | 68.91% <ø> (ø) |
|
| Go | 83.18% <95.91%> (-0.01%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/datacoord/index_meta.go | 95.87% <100.00%> (-0.03%) |
:arrow_down: |
| internal/datacoord/index_service.go | 92.94% <100.00%> (+<0.01%) |
:arrow_up: |
| internal/datacoord/task_scheduler.go | 90.44% <100.00%> (ø) |
|
| internal/querycoordv2/checkers/index_checker.go | 79.09% <100.00%> (+0.38%) |
:arrow_up: |
| internal/querycoordv2/task/executor.go | 80.93% <100.00%> (+1.25%) |
:arrow_up: |
| pkg/util/merr/utils.go | 84.00% <100.00%> (ø) |
|
| internal/querycoordv2/meta/coordinator_broker.go | 91.40% <91.30%> (-0.06%) |
:arrow_down: |
- Flaky Tests Detection - Detect and resolve failed and flaky tests
- JS Bundle Analysis - Avoid shipping oversized bundles
@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.
@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.
rerun go-sdk
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bigsheeper, czs007, xiaocai2333
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/datacoord/OWNERS~~ [czs007]
- ~~internal/querycoordv2/checkers/OWNERS~~ [czs007]
- ~~internal/querycoordv2/meta/OWNERS~~ [czs007]
- ~~internal/querycoordv2/task/OWNERS~~ [czs007]
- ~~pkg/util/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment