milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: Reduce GetIndexInfos calls

Open bigsheeper opened this issue 1 year ago • 4 comments

Batch GetIndexInfos calls for segments to reduce RPC calls.

issue: https://github.com/milvus-io/milvus/issues/37634

bigsheeper avatar Nov 14 '24 12:11 bigsheeper

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 14 '24 13:11 mergify[bot]

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.67%. Comparing base (4820dd7) to head (b3cbe49). Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
internal/querycoordv2/meta/coordinator_broker.go 91.30% 2 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37695      +/-   ##
==========================================
- Coverage   80.67%   80.67%   -0.01%     
==========================================
  Files        1357     1357              
  Lines      190739   190736       -3     
==========================================
- Hits       153883   153874       -9     
- Misses      31428    31429       +1     
- Partials     5428     5433       +5     
Components Coverage Δ
Client 61.25% <ø> (ø)
Core 68.91% <ø> (ø)
Go 83.18% <95.91%> (-0.01%) :arrow_down:
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 95.87% <100.00%> (-0.03%) :arrow_down:
internal/datacoord/index_service.go 92.94% <100.00%> (+<0.01%) :arrow_up:
internal/datacoord/task_scheduler.go 90.44% <100.00%> (ø)
internal/querycoordv2/checkers/index_checker.go 79.09% <100.00%> (+0.38%) :arrow_up:
internal/querycoordv2/task/executor.go 80.93% <100.00%> (+1.25%) :arrow_up:
pkg/util/merr/utils.go 84.00% <100.00%> (ø)
internal/querycoordv2/meta/coordinator_broker.go 91.40% <91.30%> (-0.06%) :arrow_down:

... and 39 files with indirect coverage changes

---- 🚨 Try these New Features:

codecov[bot] avatar Nov 14 '24 14:11 codecov[bot]

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 15 '24 07:11 mergify[bot]

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 16 '24 04:11 mergify[bot]

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 16 '24 07:11 mergify[bot]

rerun go-sdk

bigsheeper avatar Nov 18 '24 08:11 bigsheeper

/approve

czs007 avatar Nov 19 '24 06:11 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 19 '24 06:11 sre-ci-robot