milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: refine meta cache log and logic

Open xiaofan-luan opened this issue 1 year ago • 14 comments

related to #36989 add more logs in proxy meta cache and make it clearer

xiaofan-luan avatar Oct 30 '24 22:10 xiaofan-luan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Oct 30 '24 22:10 sre-ci-robot

@xiaofan-luan go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Oct 30 '24 22:10 mergify[bot]

Codecov Report

Attention: Patch coverage is 85.93750% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.68%. Comparing base (3d28d99) to head (0bd7a3f). Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/impl.go 68.96% 7 Missing and 2 partials :warning:
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #37318   +/-   ##
=======================================
  Coverage   80.68%   80.68%           
=======================================
  Files        1358     1358           
  Lines      191097   191097           
=======================================
+ Hits       154179   154194   +15     
+ Misses      31483    31473   -10     
+ Partials     5435     5430    -5     
Components Coverage Δ
Client 61.25% <ø> (ø)
Core 68.85% <ø> (ø)
Go 83.21% <85.93%> (+<0.01%) :arrow_up:
Files with missing lines Coverage Δ
internal/proxy/meta_cache.go 90.70% <100.00%> (+0.52%) :arrow_up:
internal/proxy/task.go 87.03% <ø> (-0.02%) :arrow_down:
internal/rootcoord/alter_collection_task.go 95.18% <100.00%> (ø)
internal/rootcoord/create_partition_task.go 91.39% <100.00%> (+0.09%) :arrow_up:
internal/proxy/impl.go 84.92% <68.96%> (-0.15%) :arrow_down:

... and 33 files with indirect coverage changes

---- 🚨 Try these New Features:

codecov[bot] avatar Oct 30 '24 22:10 codecov[bot]

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 31 '24 04:10 mergify[bot]

/run-cpu-e2e

xiaofan-luan avatar Oct 31 '24 04:10 xiaofan-luan

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 31 '24 05:10 mergify[bot]

/run-cpu-e2e

xiaofan-luan avatar Oct 31 '24 17:10 xiaofan-luan

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 01 '24 02:11 mergify[bot]

/run-cpu-e2e

xiaofan-luan avatar Nov 01 '24 03:11 xiaofan-luan

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 01 '24 04:11 mergify[bot]

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 14 '24 20:11 mergify[bot]

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 14 '24 23:11 mergify[bot]

/run-cpu-e2e

xiaofan-luan avatar Nov 14 '24 23:11 xiaofan-luan

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 15 '24 01:11 mergify[bot]

@xiaofan-luan go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 16 '24 05:11 mergify[bot]

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 16 '24 05:11 mergify[bot]

@xiaofan-luan go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 18 '24 02:11 mergify[bot]

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 18 '24 02:11 mergify[bot]

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 18 '24 06:11 mergify[bot]

@xiaofan-luan go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 18 '24 09:11 mergify[bot]

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 18 '24 10:11 mergify[bot]

@xiaofan-luan cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Nov 18 '24 20:11 mergify[bot]

@xiaofan-luan go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 18 '24 20:11 mergify[bot]

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 18 '24 21:11 mergify[bot]

/lgtm

czs007 avatar Nov 19 '24 02:11 czs007