milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: make delegator lock critical smaller

Open chyezh opened this issue 1 year ago • 3 comments

issue: #36804

chyezh avatar Oct 18 '24 09:10 chyezh

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.35%. Comparing base (8669153) to head (0d5be22). Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36997      +/-   ##
==========================================
- Coverage   80.64%   72.35%   -8.30%     
==========================================
  Files        1310     1310              
  Lines      183578   183597      +19     
==========================================
- Hits       148054   132848   -15206     
- Misses      30393    45635   +15242     
+ Partials     5131     5114      -17     
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator_data.go 85.54% <100.00%> (-0.92%) :arrow_down:

... and 244 files with indirect coverage changes

codecov[bot] avatar Oct 18 '24 11:10 codecov[bot]

/lgtm

weiliu1031 avatar Oct 21 '24 02:10 weiliu1031

/approve

czs007 avatar Oct 21 '24 03:10 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Oct 21 '24 03:10 sre-ci-robot