milvus
milvus copied to clipboard
fix: Refine compactionTask to avoid data race
issue: #36897
Codecov Report
Attention: Patch coverage is 89.47368% with 32 lines in your changes missing coverage. Please review.
Project coverage is 80.70%. Comparing base (
8902e22) to head (0a03b80). Report is 8 commits behind head on master.
:exclamation: Current head 0a03b80 differs from pull request most recent head c609386
Please upload reports for the commit c609386 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #36936 +/- ##
==========================================
- Coverage 83.26% 80.70% -2.56%
==========================================
Files 1027 1310 +283
Lines 156540 183555 +27015
==========================================
+ Hits 130340 148138 +17798
- Misses 21051 30289 +9238
+ Partials 5149 5128 -21
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/datacoord/compaction_queue.go | 85.84% <100.00%> (ø) |
|
| internal/datacoord/compaction_task.go | 100.00% <100.00%> (+10.00%) |
:arrow_up: |
| internal/datacoord/compaction_task_l0.go | 94.62% <95.08%> (-2.61%) |
:arrow_down: |
| internal/datacoord/compaction_task_mix.go | 63.11% <94.64%> (+6.39%) |
:arrow_up: |
| internal/datacoord/compaction_task_clustering.go | 79.06% <90.16%> (+2.92%) |
:arrow_up: |
| internal/datacoord/compaction.go | 72.07% <75.86%> (ø) |
@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@wayblink go-sdk check failed, comment rerun go-sdk can trigger the job again.
/lgtm
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: czs007, wayblink
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/datacoord/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment