milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: Refine compactionTask to avoid data race

Open wayblink opened this issue 1 year ago • 5 comments

issue: #36897

wayblink avatar Oct 16 '24 12:10 wayblink

Codecov Report

Attention: Patch coverage is 89.47368% with 32 lines in your changes missing coverage. Please review.

Project coverage is 80.70%. Comparing base (8902e22) to head (0a03b80). Report is 8 commits behind head on master.

:exclamation: Current head 0a03b80 differs from pull request most recent head c609386

Please upload reports for the commit c609386 to get more accurate results.

Files with missing lines Patch % Lines
internal/datacoord/compaction.go 75.86% 13 Missing and 1 partial :warning:
internal/datacoord/compaction_task_clustering.go 90.16% 10 Missing and 2 partials :warning:
internal/datacoord/compaction_task_l0.go 95.08% 2 Missing and 1 partial :warning:
internal/datacoord/compaction_task_mix.go 94.64% 3 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36936      +/-   ##
==========================================
- Coverage   83.26%   80.70%   -2.56%     
==========================================
  Files        1027     1310     +283     
  Lines      156540   183555   +27015     
==========================================
+ Hits       130340   148138   +17798     
- Misses      21051    30289    +9238     
+ Partials     5149     5128      -21     
Files with missing lines Coverage Δ
internal/datacoord/compaction_queue.go 85.84% <100.00%> (ø)
internal/datacoord/compaction_task.go 100.00% <100.00%> (+10.00%) :arrow_up:
internal/datacoord/compaction_task_l0.go 94.62% <95.08%> (-2.61%) :arrow_down:
internal/datacoord/compaction_task_mix.go 63.11% <94.64%> (+6.39%) :arrow_up:
internal/datacoord/compaction_task_clustering.go 79.06% <90.16%> (+2.92%) :arrow_up:
internal/datacoord/compaction.go 72.07% <75.86%> (ø)

... and 362 files with indirect coverage changes

codecov[bot] avatar Oct 17 '24 04:10 codecov[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 17 '24 08:10 mergify[bot]

@wayblink go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Oct 17 '24 08:10 mergify[bot]

/lgtm

xiaocai2333 avatar Oct 18 '24 07:10 xiaocai2333

/approve /lgtm

czs007 avatar Oct 23 '24 11:10 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Oct 23 '24 11:10 sre-ci-robot