milvus
milvus copied to clipboard
fix: Fix collection leak in querynode
Remove the reference counting and replace it with the ReleaseCollection RPC.
issue: https://github.com/milvus-io/milvus/issues/36918
@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
Codecov Report
Attention: Patch coverage is 89.09091% with 6 lines in your changes missing coverage. Please review.
Project coverage is 80.65%. Comparing base (
8669153) to head (1bc342a). Report is 13 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/querycoordv2/job/utils.go | 81.25% | 2 Missing and 1 partial :warning: |
| internal/querycoordv2/session/cluster.go | 75.00% | 2 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #36927 +/- ##
=======================================
Coverage 80.64% 80.65%
=======================================
Files 1310 1310
Lines 183578 183578
=======================================
+ Hits 148054 148056 +2
+ Misses 30393 30390 -3
- Partials 5131 5132 +1
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/querycoordv2/job/job_release.go | 79.04% <100.00%> (+0.20%) |
:arrow_up: |
| internal/querycoordv2/services.go | 85.26% <ø> (ø) |
|
| internal/querynodev2/segments/collection.go | 93.00% <100.00%> (+0.39%) |
:arrow_up: |
| internal/querynodev2/services.go | 91.39% <100.00%> (+0.45%) |
:arrow_up: |
| internal/querycoordv2/job/utils.go | 81.63% <81.25%> (-0.08%) |
:arrow_down: |
| internal/querycoordv2/session/cluster.go | 79.83% <75.00%> (-0.26%) |
:arrow_down: |
/run-cpu-e2e
@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
rerun ut
/lgtm
If ReleaseCollection fails, it only logs a warning, which can still lead to a collection leak in the query node.