milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: Fix collection leak in querynode

Open bigsheeper opened this issue 1 year ago • 8 comments

Remove the reference counting and replace it with the ReleaseCollection RPC.

issue: https://github.com/milvus-io/milvus/issues/36918

bigsheeper avatar Oct 16 '24 08:10 bigsheeper

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 16 '24 09:10 mergify[bot]

Codecov Report

Attention: Patch coverage is 89.09091% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.65%. Comparing base (8669153) to head (1bc342a). Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
internal/querycoordv2/job/utils.go 81.25% 2 Missing and 1 partial :warning:
internal/querycoordv2/session/cluster.go 75.00% 2 Missing and 1 partial :warning:
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36927   +/-   ##
=======================================
  Coverage   80.64%   80.65%           
=======================================
  Files        1310     1310           
  Lines      183578   183578           
=======================================
+ Hits       148054   148056    +2     
+ Misses      30393    30390    -3     
- Partials     5131     5132    +1     
Files with missing lines Coverage Δ
internal/querycoordv2/job/job_release.go 79.04% <100.00%> (+0.20%) :arrow_up:
internal/querycoordv2/services.go 85.26% <ø> (ø)
internal/querynodev2/segments/collection.go 93.00% <100.00%> (+0.39%) :arrow_up:
internal/querynodev2/services.go 91.39% <100.00%> (+0.45%) :arrow_up:
internal/querycoordv2/job/utils.go 81.63% <81.25%> (-0.08%) :arrow_down:
internal/querycoordv2/session/cluster.go 79.83% <75.00%> (-0.26%) :arrow_down:

... and 18 files with indirect coverage changes

codecov[bot] avatar Oct 16 '24 10:10 codecov[bot]

/run-cpu-e2e

bigsheeper avatar Oct 16 '24 11:10 bigsheeper

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 16 '24 12:10 mergify[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper To complete the pull request process, please assign yanliang567 after the PR has been reviewed. You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Oct 17 '24 12:10 sre-ci-robot

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 18 '24 08:10 mergify[bot]

/run-cpu-e2e

bigsheeper avatar Oct 18 '24 08:10 bigsheeper

rerun ut

bigsheeper avatar Oct 21 '24 02:10 bigsheeper

/lgtm

weiliu1031 avatar Oct 21 '24 06:10 weiliu1031

If ReleaseCollection fails, it only logs a warning, which can still lead to a collection leak in the query node.

bigsheeper avatar Oct 22 '24 09:10 bigsheeper