milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: Limit import job number

Open bigsheeper opened this issue 1 year ago • 6 comments

issue: https://github.com/milvus-io/milvus/issues/36890

bigsheeper avatar Oct 15 '24 12:10 bigsheeper

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.67%. Comparing base (8669153) to head (949a893). Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/services.go 90.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36891      +/-   ##
==========================================
+ Coverage   80.64%   80.67%   +0.02%     
==========================================
  Files        1310     1310              
  Lines      183578   183617      +39     
==========================================
+ Hits       148054   148133      +79     
+ Misses      30393    30371      -22     
+ Partials     5131     5113      -18     
Files with missing lines Coverage Δ
internal/datacoord/import_job.go 100.00% <100.00%> (ø)
internal/datacoord/import_meta.go 95.09% <100.00%> (+1.46%) :arrow_up:
pkg/util/paramtable/component_param.go 98.27% <100.00%> (+<0.01%) :arrow_up:
internal/datacoord/services.go 85.40% <90.00%> (+0.08%) :arrow_up:

... and 22 files with indirect coverage changes

codecov[bot] avatar Oct 15 '24 14:10 codecov[bot]

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 16 '24 10:10 mergify[bot]

/run-cpu-e2e

bigsheeper avatar Oct 16 '24 11:10 bigsheeper

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 18 '24 09:10 mergify[bot]

/run-cpu-e2e

bigsheeper avatar Oct 21 '24 02:10 bigsheeper

/approve /lgtm

czs007 avatar Oct 23 '24 07:10 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Oct 23 '24 07:10 sre-ci-robot