@W-15929693 - Milvus 2.3 Index file changes , rc - incorporated (#32)

[roy-akash]

trafficstars

[sre-ci-robot]

Welcome @roy-akash! It looks like this is your first PR to milvus-io/milvus 🎉

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: roy-akash To complete the pull request process, please assign wxyucs after the PR has been reviewed. You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[mergify[bot]]

@roy-akash Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

[mergify[bot]]

@roy-akash Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

[mergify[bot]]

@roy-akash

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

1. Title Format: The PR title must begin with one of these prefixes:

• feat: for introducing a new feature.
• fix: for bug fixes.
• enhance: for improvements to existing functionality.
• test: for add tests to existing functionality.
• doc: for modifying documentation.
• auto: for the pull request from bot.

2. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

[mergify[bot]]

@roy-akash E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 75.96899% with 31 lines in your changes missing coverage. Please review.

Project coverage is 83.08%. Comparing base (abb58a6) to head (f9423fd). Report is 10 commits behind head on 2.3.

Files with missing lines	Patch %	Lines
internal/datacoord/garbage_collector.go	51.85%	10 Missing and 3 partials :warning:
pkg/util/metautil/segment_index.go	0.00%	9 Missing :warning:
internal/core/src/storage/ChunkManagers.cpp	0.00%	4 Missing :warning:
internal/datacoord/index_service.go	40.00%	1 Missing and 2 partials :warning:
internal/core/src/indexbuilder/index_c.cpp	0.00%	1 Missing :warning:
internal/core/src/storage/MinioChunkManager.h	0.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##              2.3   #35994      +/-   ##
==========================================
- Coverage   83.09%   83.08%   -0.01%     
==========================================
  Files         853      853              
  Lines      107454   107510      +56     
==========================================
+ Hits        89291    89328      +37     
- Misses      14818    14831      +13     
- Partials     3345     3351       +6     

Files with missing lines	Coverage Δ
internal/core/src/storage/ChunkManager.h	100.00% <100.00%> (ø)
internal/core/src/storage/FileManager.h	90.00% <100.00%> (+1.11%)	:arrow_up:
internal/core/src/storage/Types.h	25.00% <100.00%> (+1.36%)	:arrow_up:
internal/core/src/storage/storage_c.cpp	80.64% <100.00%> (+0.31%)	:arrow_up:
internal/datacoord/index_builder.go	90.51% <100.00%> (+0.03%)	:arrow_up:
internal/datacoord/server.go	71.94% <100.00%> (+0.08%)	:arrow_up:
internal/util/indexcgowrapper/build_index_info.go	89.01% <100.00%> (+0.12%)	:arrow_up:
internal/util/initcore/init_core.go	88.37% <100.00%> (+0.13%)	:arrow_up:
pkg/util/paramtable/component_param.go	98.32% <100.00%> (+<0.01%)	:arrow_up:
internal/core/src/indexbuilder/index_c.cpp	29.09% <0.00%> (-0.10%)	:arrow_down:
... and 5 more

... and 14 files with indirect coverage changes

[roy-akash]

Hi team this PR aims in aligning the index_files URI scheme. This pr adds a flag in the milvus yaml useCollectionIdBasedIndexPath, this flag is by default false and if its true then

all operations on index_files from go code and cpp code would add collection_id after the index_files directory to read and write indexes.

Work is in progress for the unit test cases for the same

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

[roy-akash]

/reopen

[sre-ci-robot]

@roy-akash: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.