milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: Skip update collection next target if segment/channel list doesn't change

Open weiliu1031 opened this issue 1 year ago • 12 comments
trafficstars

issue: #34715

if querycoord update next target with same segment/channel list, then it will be apply to current target immediately. and target version will change when update current target, which will trigger SyncDistribution every 10 seconds.

This PR add the check logic to skip update collection next target if segment/channel list doesn't changes.

weiliu1031 avatar Jul 16 '24 06:07 weiliu1031

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031 To complete the pull request process, please assign yanliang567 after the PR has been reviewed. You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jul 16 '24 06:07 sre-ci-robot

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 16 '24 08:07 mergify[bot]

/run-cpu-e2e

weiliu1031 avatar Jul 16 '24 09:07 weiliu1031

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 18 '24 04:07 mergify[bot]

rerun ut

weiliu1031 avatar Jul 19 '24 03:07 weiliu1031

/run-cpu-e2e

weiliu1031 avatar Jul 19 '24 03:07 weiliu1031

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 19 '24 05:07 mergify[bot]

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 20 '24 12:07 mergify[bot]

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 22 '24 05:07 mergify[bot]

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 23 '24 07:07 mergify[bot]

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 26 '24 04:07 mergify[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Aug 25 '24 04:08 stale[bot]