milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: Revert a optimize in clustering compaction

Open wayblink opened this issue 1 year ago • 2 comments

#30633

wayblink avatar Jul 01 '24 08:07 wayblink

/lgtm

xiaocai2333 avatar Jul 01 '24 09:07 xiaocai2333

rerun ut

xiaocai2333 avatar Jul 02 '24 09:07 xiaocai2333

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.83%. Comparing base (e5d691d) to head (0091aca). Report is 20 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34299      +/-   ##
==========================================
+ Coverage   80.44%   80.83%   +0.39%     
==========================================
  Files        1086     1084       -2     
  Lines      137670   137522     -148     
==========================================
+ Hits       110744   111168     +424     
+ Misses      22756    22151     -605     
- Partials     4170     4203      +33     
Files Coverage Δ
internal/datacoord/compaction_task_clustering.go 47.07% <100.00%> (+21.05%) :arrow_up:

... and 123 files with indirect coverage changes

codecov[bot] avatar Jul 02 '24 20:07 codecov[bot]

/approve

congqixia avatar Jul 03 '24 02:07 congqixia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jul 03 '24 02:07 sre-ci-robot