milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: [Cherry-Pick] Update access log

Open aoiasd opened this issue 1 year ago • 1 comments

Support restful api,print with consistency level and add new write cache. relate: https://github.com/milvus-io/milvus/issues/31823 pr: https://github.com/milvus-io/milvus/pull/33155

aoiasd avatar Jul 01 '24 07:07 aoiasd

Codecov Report

Attention: Patch coverage is 88.96552% with 48 lines in your changes missing coverage. Please review.

Project coverage is 81.83%. Comparing base (fc6bd38) to head (17234ac). Report is 19 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.4   #34295   +/-   ##
=======================================
  Coverage   81.82%   81.83%           
=======================================
  Files        1010     1016    +6     
  Lines      130787   130841   +54     
=======================================
+ Hits       107021   107078   +57     
+ Misses      19766    19744   -22     
- Partials     4000     4019   +19     
Files Coverage Δ
internal/distributed/proxy/httpserver/utils.go 87.89% <100.00%> (+0.12%) :arrow_up:
internal/distributed/proxy/service.go 84.13% <100.00%> (+0.04%) :arrow_up:
internal/proxy/accesslog/info/grpc_info.go 98.41% <100.00%> (+1.71%) :arrow_up:
internal/proxy/accesslog/info/info.go 93.87% <100.00%> (+0.26%) :arrow_up:
internal/proxy/accesslog/writer.go 86.34% <100.00%> (+6.77%) :arrow_up:
pkg/util/paramtable/component_param.go 98.38% <100.00%> (+<0.01%) :arrow_up:
pkg/util/requestutil/getter.go 100.00% <100.00%> (ø)
internal/proxy/accesslog/global.go 79.20% <66.66%> (-0.80%) :arrow_down:
internal/proxy/accesslog/util.go 61.76% <83.33%> (+11.76%) :arrow_up:
...nternal/distributed/proxy/httpserver/handler_v1.go 91.35% <91.20%> (+0.10%) :arrow_up:
... and 2 more

... and 224 files with indirect coverage changes

codecov[bot] avatar Jul 01 '24 11:07 codecov[bot]

/lgtm

PowderLi avatar Jul 02 '24 07:07 PowderLi

/approve

czs007 avatar Jul 02 '24 07:07 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jul 02 '24 07:07 sre-ci-robot