milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: Don't set timeout for SyncSegments

Open xiaocai2333 opened this issue 1 year ago • 2 comments

issue: #32809

master pr: #34226

xiaocai2333 avatar Jul 01 '24 06:07 xiaocai2333

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 01 '24 07:07 mergify[bot]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.84%. Comparing base (3c5ad49) to head (318f060). Report is 5 commits behind head on 2.4.

:exclamation: Current head 318f060 differs from pull request most recent head 9da0b2b

Please upload reports for the commit 9da0b2b to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #34291       +/-   ##
===========================================
+ Coverage   70.40%   81.84%   +11.43%     
===========================================
  Files        1013     1015        +2     
  Lines      131418   130618      -800     
===========================================
+ Hits        92529   106905    +14376     
+ Misses      34860    19706    -15154     
+ Partials     4029     4007       -22     
Files Coverage Δ
internal/datacoord/session_manager.go 82.87% <0.00%> (+12.21%) :arrow_up:

... and 301 files with indirect coverage changes

codecov[bot] avatar Jul 01 '24 10:07 codecov[bot]

/run-cpu-e2e

xiaocai2333 avatar Jul 01 '24 11:07 xiaocai2333

/approve /lgtm

czs007 avatar Jul 02 '24 06:07 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jul 02 '24 06:07 sre-ci-robot